Re: [PATCH] xfail gdb.base/break-on-linker-gcd-function.exp with Solaris ld [PR34534]
Tom Tromey <[email protected]>
| Newsgroups | gmane.comp.gdb.patches |
|---|---|
| Message-ID | <[email protected]> |
>>>>> "Rainer" == Rainer Orth <[email protected]> writes: Rainer> Even though ld supports --gc-sections as an alias for the native -z Rainer> discard-unused=sections, this doesn't work in this particular case. Rainer> While the issue is under investigation, this patch xfail's the test when Rainer> Solaris ld is in use. Rainer> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=34534 Rainer> Ok for trunk? A few tiny nits, ok with these fixed. Approved-By: Tom Tromey <[email protected]> Rainer> + # PR 34534 Write 'PR testsuite/34534'. This is the usual format and works automatically with Emacs due to gdb/.dir-locals.el. Rainer> + if [regexp "Solaris Link Editors" $output] { Nowadays I think we brace if expressions, so "if {[...]} " thanks, Tom