Re: [PATCH v1] Fix wrong build tree in python.exp path on AIX
Tom Tromey <[email protected]>
| Newsgroups | gmane.comp.gdb.patches |
|---|---|
| Message-ID | <[email protected]> |
>>>>> Aditya Vidyadhar Kamath <[email protected]> writes: > From: Aditya Kamath <[email protected]> > Python records the path to the export file in LINKFORSHARED sysconfig > variable as a build tree relative path: -Wl,bE:Modules/python.exp > But this will fail in AIX. When configure runs python-config.py --ldflags to test for > libpython, the linker cannot find Modules/python.exp, the link test > fails, and GDB is built without Python support. > So in this patch we fix the same by replacing the relative path with LIBPL/python.exp (e.g. > /opt/freeware/lib64/python3.12/config-3.12/python.exp) on AIX only, > where LIBPL is the installed config directory that already contains > the file. Thanks for the patch. I don't really understand this, but (1) I didn't see any other commentary on it and (2) it seems to be AIX-specific. So, I think it is ok. I appreciate the comment in there. It's fine if you want to apply this to the gdb-18 branch as well. Approved-By: Tom Tromey <[email protected]> Tom