Re: [PATCH v4 08/10] gdb: add objfile -> solib backlink
Tom Tromey <[email protected]>
| Newsgroups | gmane.comp.gdb.patches |
|---|---|
| Message-ID | <[email protected]> |
>>>>> "Simon" == Simon Marchi <[email protected]> writes: Simon> From: Simon Marchi <[email protected]> Simon> The following "multiple solib_ops" patch will require accessing the Simon> solib(s) related to an objfile fairly often. To make that easier, add Simon> an objfile to solib backlink. Simon> However, I learned that there may be more than one solib linked to one Simon> objfile. The only case I am aware of is the dynamic linker itself Simon> (ld-linux.so), where the same instance (same load address) appears in Simon> all namespaces. We get one solib per "view" of that library, but they Simon> all point to the same objfile. So this backlink is actually a vector. Simon> Rename find_solib_for_objfile to find_one_solib_for_objfile to reflect Simon> that this function returns just one of possible multiple solibs for the Simon> given objfile (if that ever matters). To be clear, this doesn't change Simon> its behavior, this is what it was doing before this patch. Looks good, thanks. Approved-By: Tom Tromey <[email protected]> Tom