Re: [PATCH 1/2] gdb: add default parameter for cp_demangled_name_to_comp errmsg

On 8/21/26 11:05 AM, Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi <[email protected]> writes:
> 
> Simon> I am generally not a big fan of default values, especially when the
> Simon> parameter changes how the function behaves.  But in this case it does
> Simon> really change the behavior of the function, so I think it's fine.
> 
> I think maybe you left out a "not" from the second sentence here.
> 
> Anyway this looks good to me.
> Approved-By: Tom Tromey <[email protected]>
> 
> Tom

I pushed both patches, but I forgot to address you comment about the
commit message, sorry.

Simon