Re: [PATCH] Skip gdb.dap/pause.exp on Solaris [PR34548]
Rainer Orth <[email protected]>
| Newsgroups | gmane.comp.gdb.patches |
|---|---|
| Message-ID | <[email protected]> |
Hi Tom, >>>>>> "Rainer" == Rainer Orth <[email protected]> writes: > > Rainer> As detailed in PR PR dap/34548, the gdb.dap/pause.exp test runs > Rainer> indefinitely on Solaris. To allow make check to finish, it needs to be > Rainer> terminated manually. > > Rainer> To avoid this, this patch skips the test. > > Rainer> Tested on x86_64-pc-solaris2.11, sparcv9-sun-solaris2.11, and > Rainer> x86_64-pc-linux-gnu. > > Rainer> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=34548 > > Rainer> Ok for trunk? > > This is fine, but in the bug you mentioned other reports about target > async not working. not actually reports, just ca. 100 instances of the Asynchronous execution not supported on this target. message in the full testsuite log. Some of them already turn the tests UNSUPPORTED, while others cause the tests to FAIL. > So maybe DAP testing should be entirely disabled for Solaris? Like just returning 0 from allow_dap_tests on Solaris? Or doing so for all targets lacking async support? Here's a breakdown of gdb.dap results on Solaris: 8 ERROR 11 FAIL 713 PASS 8 PATH 8 UNRESOLVED 2 UNSUPPORTED I can't tell if it's still useful this way. > Rainer> This might also be a candidate for the gdb-18 branch. > > It's fine by me. Thanks. I'll way for approval from a release manager then. Rainer -- ----------------------------------------------------------------------------- Rainer Orth, Center for Biotechnology, Bielefeld University