Re: [PATCH 3/5] Fix weird quoting in stap-probe.c
Eli Zaretskii <[email protected]>
| Newsgroups | gmane.comp.gdb.patches |
|---|---|
| Message-ID | <[email protected]> |
> From: Tom Tromey <[email protected]> > Date: Sat, 22 Aug 2026 14:30:05 -0600 > Cc: Tom Tromey <[email protected]> > > I found some code in stap-probe.c that split the quoting in a strange > way: > > warning (_("unrecognized bitness %s%c' for probe `%s'"), > got_minus ? "`-" : "`", *cur, > > Here the leading ` is not part of the format string. I found this odd > and so I split this fix out into its own patch. This changes the quoting style of "-7" and the like. As the test suite shows, it was previously quoted as `-7'. Is there a good reason for this change? I'm not sure I understand what is weird about this quoting or ` not being part of the format string. Is this just a style-preference thing?