Re: [PATCH 2/2] gdb: share some thread proceed related code between CLI and MI

Tom de Vries <[email protected]> writes:

> On 8/7/26 5:31 PM, Andrew Burgess wrote:
>> Tom de Vries <[email protected]> writes:
>> 
>>> On 8/6/26 10:54 PM, Andrew Burgess wrote:
>>>> +	  if (inf == nullptr)
>>>> +	    proceed_all_threads ();
>>>> +	  else
>>>> +	    {
>>>> +	      for (thread_info &thread : inf->threads ())
>>>> +		proceed_one_thread (thread);
>>>>    	    }
>>>
>>> FWIW, also I wonder if it makes sense to fold this logic into
>>> proceed_all_threads:
>> 
>> I took a look through all the other proceed() calls and couldn't see
>> anything else that might want to share this code, so my preference would
>> be to leave things as I initially proposed.  I like the simpler each
>> function has one clear goal, rather than overloading proceed_all_threads
>> with multiple meanings ("all threads", or "all threads in inferior").
>> Especially not a fan of default arguments for cases like this (or in
>> general much).
>> 
>> That said, if you consider this a blocker to merging this patch then I
>> don't feel that strongly against it so would make the change to get this
>> fix merged.
>> 
>
> Hi Andrew,
>
> I don't consider this a blocker.

Great.

I've now pushed these patches.

Thanks,
Andrew