Re: pscoast: GMT_non_zero_winding given non-closed polygon

Joaquim wrote:
> Thanks for this extended test. I would also say that the double free=20
> does indeed seams to exist but it's so strange that I don't catch it=20
> with MSVC that is way more picky with those things than gcc or clang.

Hi Joaquim,

The (-pedantic) Debian build log didn't see much either, but I doubt that w=
ould catch many Valgrind-style memory issues.

fwiw, here is all of what it complains about in 4.5.12:

gcc -fPIC -ansi -pedantic -O2 -I/=ABPKGBUILDDIR=BB/src -I/usr/include     -=
c -o mgd77.o mgd77.c
mgd77.c: In function 'MGD77_Write_Header_Record_m77t':
mgd77.c:1859:2: warning: string length '575' is greater than the length '50=
9' ISO C90 compilers are required to support [-Woverlength-strings]
  GMT_fputs (MGD77T_HEADER, F->fp);     GMT_fputs ("\n", F->fp);
  ^


gcc -fPIC -ansi -pedantic -O2 -I/=ABPKGBUILDDIR=BB/src -I/usr/include     -=
c -o mgd77header.o mgd77header.c
mgd77header.c: In function 'main':
mgd77header.c:60:2: warning: ISO C90 forbids mixed declarations and code [-=
Wpedantic]
  char *tvalue[MGD77_MAX_COLS], buffer[BUFSIZ], **list =3D NULL, name[BUFSI=
Z], value[BUFSIZ], params[BUFSIZ], hinfile[BUFSIZ], line[BUFSIZ];
  ^


gcc -fPIC -ansi -pedantic -O2 -I/=ABPKGBUILDDIR=BB/src  -I/usr/include     =
-c -o xgrid_textView.o xgrid_textView.c
xgrid_textView.c: In function 'scrollHorizontal':
xgrid_textView.c:330:12: warning: cast from pointer to integer of different=
 size [-Wpointer-to-int-cast]
   int  x =3D (int)call_data;
            ^
xgrid_textView.c: In function 'scrollVertical':
xgrid_textView.c:378:12: warning: cast from pointer to integer of different=
 size [-Wpointer-to-int-cast]
   int  y =3D (int)call_data;
            ^


All pretty clean on the whole!


> Also, did you try with GMT5? Our GMT5 test suite can (and is time to=20
> time) be run under valgrind, which is supposed to catch these type of=20
> problems.

Debian packaging for GMT5 + cmake has begun, but it is not ready yet:
(I tried)
 http://anonscm.debian.org/cgit/pkg-grass/gmt.git/log/
 http://article.gmane.org/gmane.linux.debian.gis/596
 https://bugs.debian.org/747269


GMT5 is a goal for the next stable release of Debian, but the real problem =
here is for Ubuntu 14.04 LTS, which is already locked at
4.5.11 for the next 5+ years. We can backport patches and change
compiler settings, but we can only do upgraded versions in 3rd party
PPAs (i.e. UbuntuGIS's package & backports repository)

As it is the next release of OSGeo Live DVD is about to go to the
printers for FOSS4G 2014 with a broken GMT demo, which makes me sad.
 :-(
http://live.osgeo.org


thanks & regards,
Hamish

Mailing list for GMT discussions of all kinds.  If you are not sure you have found a bug, discuss it here first.
To formally report bugs or request features, please register and add New Issue on gmt.soest.hawaii.edu
To unsubscribe, send the message "signoff gmt-help" to [email protected]
Note: gmt-help will become obsolete on Sept 1, 2014 - please use forum on gmt.soest.hawaii.edu instead.