Re: best practices for subject lines of PR
Stefan Blumentrath <[email protected]>
| Newsgroups | gmane.comp.gis.grass.devel |
|---|---|
| Message-ID | <VI1PR02MB5038C9FA15D93FE9EAB8B3A69EA20@VI1PR02MB5038.eurprd02.prod.outlook.com> |
Hi, Yes, I would also be very interested in some guidance on this! Maybe add them also here: https://github.com/OSGeo/grass/blob/master/CONTRIBUTING.md Cheers Stefan -----Original Message----- From: grass-dev <[email protected]> On Behalf Of Moritz Lennert Sent: fredag 8. mai 2020 16:41 To: grass-dev <[email protected]> Subject: [GRASS-dev] best practices for subject lines of PR Hi, A few days ago, we had a discussion about good labelling of PRs/commits in order to make it easier to create News pages for new releases. I just opened PR #601 [1] which changes the API of the v.distance module. Is there a specific label I should put into the subject line of this PR to mark the API change ? Similar question for PR #534 [2] in which I added new functionality to v.neighbor. I added [NEW FUNCTIONALITY] into the subject line in order to make it apparent, but in a certain way this is redundant with the 'enhancement' tag. So, could anyone provide some guidance concerning the best way to label/tab/entitle these PRs ? Moritz [1] https://github.com/OSGeo/grass/pull/601 [2] https://github.com/OSGeo/grass/pull/534 _______________________________________________ grass-dev mailing list [email protected] https://lists.osgeo.org/mailman/listinfo/grass-dev _______________________________________________ grass-dev mailing list [email protected] https://lists.osgeo.org/mailman/listinfo/grass-dev