Re: ParallelModuleQueue freezes...

Stefan Blumentrath <[email protected]> Fri, 28 May 2021 14:02:01 +0000
Newsgroups gmane.comp.gis.grass.devel
Message-ID <VI1PR02MB50381EA3F811A3FE50B4FBC59E229@VI1PR02MB5038.eurprd02.prod.outlook.com>
Some more context.
The t.rast.neighbors test seems to work with the current dev version
"2048e1016" from 2021-05-19T09:38:49+00:00
It fails however, with 7.8.5 from 2020-12-22T15:55:09+00:00 and an older de=
velopment version "35edbf7dc"
from 2020-06-03T16:03:52+00:00

So, maybe one or more of the recent changes need backporting?
https://github.com/OSGeo/grass/commits/master/python/grass/pygrass/modules/=
interface/module.py

In the 7_8 release branch, the latest change is from May 2019:
https://github.com/OSGeo/grass/commits/releasebranch_7_8/lib/python/pygrass=
/modules/interface/module.py

Hope that helps identifying a solution?

Cheers
Stefan

-----Original Message-----
From: Stefan Blumentrath <[email protected]> =

Sent: torsdag 27. mai 2021 23:09
To: Stefan Blumentrath <[email protected]>; Luca Delucchi <lucadel=
[email protected]>; Anna Petr=E1=B9ov=E1 <[email protected]>
Cc: GRASS developers list <[email protected]>
Subject: RE: [GRASS-dev] ParallelModuleQueue freezes...

See:
https://eur01.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgithub.=
com%2FOSGeo%2Fgrass%2Fpull%2F1600&amp;data=3D04%7C01%7C%7Cc5fe909715a647431=
c9308d92153b445%7C6cef373021314901831055b3abf02c73%7C0%7C0%7C63757746565304=
8701%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik=
1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=3D5yfxG5gjlYlzgJn6yTP9zbUk7GE1JdcYPxW=
IQFwUK%2Fo%3D&amp;reserved=3D0
Please test.
Unittests for t.rast.neighbors should work again with this small change...

-----Original Message-----
From: grass-dev <[email protected]> On Behalf Of Stefan Blu=
mentrath
Sent: torsdag 27. mai 2021 08:19
To: Luca Delucchi <[email protected]>; Anna Petr=E1=B9ov=E1 <kratochanna=
@gmail.com>
Cc: GRASS developers list <[email protected]>
Subject: Re: [GRASS-dev] ParallelModuleQueue freezes...

The combination ParallelModuleQueue and MultiModule is used in t.rast.neigh=
bors: https://eur01.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fg=
ithub.com%2FOSGeo%2Fgrass%2Fblob%2Fmaster%2Ftemporal%2Ft.rast.neighbors%2Ft=
.rast.neighbors.py&amp;data=3D04%7C01%7C%7Cc5fe909715a647431c9308d92153b445=
%7C6cef373021314901831055b3abf02c73%7C0%7C0%7C637577465653048701%7CUnknown%=
7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6M=
n0%3D%7C1000&amp;sdata=3D5QyN%2FR1cXgoWWGS2lgjKi8%2BeLX77w37bfMQzcP6O4bM%3D=
&amp;reserved=3D0

The testsuite of that module is deactivated for Python > 2.
https://eur01.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgithub.=
com%2FOSGeo%2Fgrass%2Fblob%2Fmaster%2Ftemporal%2Ft.rast.neighbors%2Ftestsui=
te%2Ftest_neighbors.py&amp;data=3D04%7C01%7C%7Cc5fe909715a647431c9308d92153=
b445%7C6cef373021314901831055b3abf02c73%7C0%7C0%7C637577465653048701%7CUnkn=
own%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXV=
CI6Mn0%3D%7C1000&amp;sdata=3DnQTdDIGmefI6F37zdjhyMDBYUrIxVaC%2FiA5FzeUK2KU%=
3D&amp;reserved=3D0

If you activate it by commenting out line 15. You will see the behavior...

Thanks for looking into this!

Cheers
Stefan


-----Original Message-----
From: Luca Delucchi <[email protected]> =

Sent: torsdag 27. mai 2021 06:07
To: Anna Petr=E1=B9ov=E1 <[email protected]>
Cc: Stefan Blumentrath <[email protected]>; GRASS developers list =
<[email protected]>
Subject: Re: [GRASS-dev] ParallelModuleQueue freezes...

On Thu, 27 May 2021 at 04:07, Anna Petr=E1=B9ov=E1 <[email protected]> =
wrote:
>
> Could you provide an example that is failing? The doctests are running fo=
r me. I spent some time fixing it a couple months ago. I use Python 3.6, I =
wonder if newer Python would cause some issues.
>

https://eur01.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgithub.=
com%2FOSGeo%2Fgrass-addons%2Fpull%2F523%2Ffiles&amp;data=3D04%7C01%7C%7Cc5f=
e909715a647431c9308d92153b445%7C6cef373021314901831055b3abf02c73%7C0%7C0%7C=
637577465653048701%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2lu=
MzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=3DKT5h55J89LLXhK7uEujAm=
IwfksjPGyXEy2u7gYIc2Ns%3D&amp;reserved=3D0 line 544, the commented lines ar=
e not working for me..
If you want to try t.vi just comment line 543 and uncomment the following l=
ines..

> Anna
>

--
ciao
Luca

https://eur01.safelinks.protection.outlook.com/?url=3Dhttp%3A%2F%2Fwww.luca=
delu.org%2F&amp;data=3D04%7C01%7C%7Cc5fe909715a647431c9308d92153b445%7C6cef=
373021314901831055b3abf02c73%7C0%7C0%7C637577465653048701%7CUnknown%7CTWFpb=
GZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7=
C1000&amp;sdata=3DhM8CpSgjw7SFjGKxM9SFfWI3G8U3nr8eeCqedZORdso%3D&amp;reserv=
ed=3D0
_______________________________________________
grass-dev mailing list
[email protected]
https://eur01.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Flists.o=
sgeo.org%2Fmailman%2Flistinfo%2Fgrass-dev&amp;data=3D04%7C01%7C%7Cc5fe90971=
5a647431c9308d92153b445%7C6cef373021314901831055b3abf02c73%7C0%7C0%7C637577=
465653048701%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLC=
JBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=3DIwP5QxiLzELTGrr393lqAWrlWRh=
BVg%2FbOhrz9lBHMkw%3D&amp;reserved=3D0