Re: Failure during Postgres major version upgrade due to deprecated long_xact funcs

Sounds good! Thanks for the follow up.

Derek

On Tue, Oct 8, 2024 at 13:37 Regina Obe <[email protected]> wrote:

> We haven’t decided on a patch version release date.  I’m thinking a little
> before PostgreSQL 17.1 would be a good time, to catch the bulk of new folks
> upgrading.
>
>
>
> I’ve ticketed the issue here -  https://trac.osgeo.org/postgis/ticket/5791
> and will address this week.
>
>
>
> Thanks for the report,
>
> Regina
>
>
>
> *From:* Kered <[email protected]>
> *Sent:* Tuesday, October 8, 2024 3:46 PM
> *To:* Regina Obe <[email protected]>
> *Subject:* Re: Failure during Postgres major version upgrade due to
> deprecated long_xact funcs
>
>
>
> Hi Regina,
>
>
>
> After adding those two to postgis_legacy.c and rebuilding it, now upgrade
> can complete. Thanks for the help!
>
>
>
> Upgrade Complete
>
> ----------------
>
> Optimizer statistics are not transferred by pg_upgrade.
>
> Once you start the new server, consider running:
>
>
>
> May I know when the new patch version will be released?
>
>
>
> Derek
>
>
>
> On Tue, Oct 8, 2024 at 12:14 PM Regina Obe <[email protected]> wrote:
>
> Thanks for the alert.  I suspect we forgot to add that function to
> postgis_legacy, so that needs to be done.  We’ll do that in next 3.4. patch
> update.
>
>
>
> For now I recommend before upgrading (especially with pg_upgrade) dropping
> it in the extension.
>
>
>
> So
>
>
>
> ALTER EXTENSION "postgis" DROP FUNCTION "public"."checkauthtrigger"()
> CASCADE;
>
>
>
>
>
>
>
>
>
> *From:* Kered <[email protected]>
> *Sent:* Tuesday, October 8, 2024 12:23 PM
> *To:* [email protected]
> *Subject:* Failure during Postgres major version upgrade due to
> deprecated long_xact funcs
>
>
>
> Hi there,
>
>
>
> I saw postgres upgrade failure with following message (pg16.1 to 17.0,
> postgis 3.4.0 to postgis 3.5.0)
>
>
>
> pg_restore: creating FUNCTION "public.checkauth("text", "text", "text")"
>
> pg_restore: creating COMMENT "public.FUNCTION "checkauth"("text", "text",
> "text")"
>
> pg_restore: creating FUNCTION "public.checkauthtrigger()"
>
> pg_restore: while PROCESSING TOC:
>
> pg_restore: from TOC entry 558; 1255 18735 FUNCTION checkauthtrigger()
> pguser
>
> pg_restore: error: could not execute query: ERROR:  could not find
> function "check_authorization" in file
> "/local/home/pguser/temp/local_pg/installs/pg170/lib/postgresql/postgis-3.so"
>
> Command was: CREATE FUNCTION "public"."checkauthtrigger"() RETURNS
> "trigger"
>
>     LANGUAGE "c"
>
>     AS '$libdir/postgis-3', 'check_authorization';
>
>
>
> -- For binary upgrade, handle extension membership the hard way
>
> ALTER EXTENSION "postgis" ADD FUNCTION "public"."checkauthtrigger"();
>
>
>
> (same for GetTransactionID)
>
>
>
> I saw a previous ticket https://trac.osgeo.org/postgis/ticket/5723  which
> tried to drop it already, but I still see this. Is this expected or
> something that was missed during testing?
>
>
>
> Best,
>
> Derek
>
>