Re: Exif-display plugin patch: desciption tag
Jonathan Michalon <[email protected]>
| Newsgroups | gmane.comp.gnome.apps.Eog |
|---|---|
| Message-ID | <[email protected]> |
Jonathan Michalon a écrit : > Hi all, > > I've just searched for a way to see the description tag of an image > simultaneously to the image itself (and not in the property window). > I've installed the Exif-display plugin, but that field is missing so I wrote a > patch accordingly. May the patch be reviewed by pros of GTK+ ? Or even, pushed > to the eog-plugins repo? Sorry for the noise, but here is a slightly enhanced patch : typo & cosmetics. Perhaps I was too happy that it worked... Jonathan _______________________________________________ Eog-list mailing list [email protected] http://mail.gnome.org/mailman/listinfo/eog-list
Add-Description-Field-2.patch
(text/x-diff, 5.6 KB)
diff --git a/plugins/exif-display/eog-exif-display-plugin.c b/plugins/exif-display/eog-exif-display-plugin.c
index 15e1418..df86fb4 100644
--- a/plugins/exif-display/eog-exif-display-plugin.c
+++ b/plugins/exif-display/eog-exif-display-plugin.c
@@ -290,6 +290,9 @@ static void manage_exif_data (WindowData *data)
set_exif_label (exif_data, EXIF_TAG_METERING_MODE,
data->sidebar_builder, "metering_mode_label", TRUE);
+
+ set_exif_label (exif_data, EXIF_TAG_USER_COMMENT,
+ data->sidebar_builder, "desc_label", TRUE);
set_exif_label (exif_data, EXIF_TAG_EXPOSURE_BIAS_VALUE, data->sidebar_builder, "exposure_bias_label", FALSE);
diff --git a/plugins/exif-display/exif-display.ui b/plugins/exif-display/exif-display.ui
index 9b66b83..995ed26 100644
--- a/plugins/exif-display/exif-display.ui
+++ b/plugins/exif-display/exif-display.ui
@@ -28,7 +28,6 @@
<child>
<object class="GtkLabel" id="takenon_label">
<property name="visible">True</property>
- <property name="xalign">0</property>
<property name="xpad">5</property>
<property name="ellipsize">end</property>
</object>
@@ -42,7 +41,7 @@
<object class="GtkTable" id="table1">
<property name="visible">True</property>
<property name="border_width">5</property>
- <property name="n_rows">6</property>
+ <property name="n_rows">7</property>
<property name="n_columns">2</property>
<property name="column_spacing">7</property>
<property name="row_spacing">5</property>
@@ -53,6 +52,9 @@
<property name="label" translatable="yes"><b>ISO speed:</b></property>
<property name="use_markup">True</property>
</object>
+ <packing>
+ <property name="x-options">GTK_FILL</property>
+ </packing>
</child>
<child>
<object class="GtkLabel" id="iso_label">
@@ -74,6 +76,7 @@
<packing>
<property name="top_attach">1</property>
<property name="bottom_attach">2</property>
+ <property name="x-options">GTK_FILL</property>
</packing>
</child>
<child>
@@ -98,6 +101,7 @@
<packing>
<property name="top_attach">2</property>
<property name="bottom_attach">3</property>
+ <property name="x-options">GTK_FILL</property>
</packing>
</child>
<child>
@@ -122,12 +126,14 @@
<packing>
<property name="top_attach">3</property>
<property name="bottom_attach">4</property>
+ <property name="x-options">GTK_FILL</property>
</packing>
</child>
<child>
<object class="GtkLabel" id="focal_length_label">
<property name="visible">True</property>
<property name="xalign">0</property>
+ <property name="ellipsize">PANGO_ELLIPSIZE_END</property>
</object>
<packing>
<property name="left_attach">1</property>
@@ -146,6 +152,7 @@
<packing>
<property name="top_attach">4</property>
<property name="bottom_attach">5</property>
+ <property name="x-options">GTK_FILL</property>
</packing>
</child>
<child>
@@ -171,6 +178,7 @@
<packing>
<property name="top_attach">5</property>
<property name="bottom_attach">6</property>
+ <property name="x-options">GTK_FILL</property>
</packing>
</child>
<child>
@@ -185,6 +193,33 @@
<property name="bottom_attach">6</property>
</packing>
</child>
+ <child>
+ <object class="GtkLabel" id="label7">
+ <property name="visible">True</property>
+ <property name="xalign">0</property>
+ <property name="label" translatable="yes"><b>Description:</b></property>
+ <property name="use_markup">True</property>
+ <property name="yalign">0</property>
+ </object>
+ <packing>
+ <property name="top_attach">6</property>
+ <property name="bottom_attach">7</property>
+ <property name="x-options">GTK_FILL</property>
+ </packing>
+ </child>
+ <child>
+ <object class="GtkLabel" id="desc_label">
+ <property name="visible">True</property>
+ <property name="xalign">0</property>
+ <property name="ellipsize">PANGO_ELLIPSIZE_END</property>
+ </object>
+ <packing>
+ <property name="left_attach">1</property>
+ <property name="right_attach">2</property>
+ <property name="top_attach">6</property>
+ <property name="bottom_attach">7</property>
+ </packing>
+ </child>
</object>
<packing>
<property name="expand">False</property>