[Patch] Enable multi-threaded POP3 retrieval

Albrecht Dreß <[email protected]>
Newsgroups gmane.comp.gnome.apps.balsa
Message-ID <[email protected]>
Hi all,

attached is a larger patch which enables multi-threaded retrieval of POP3 messages.  The biggest part of the patch is related to changes of the progress dialogue implementation, though.  It also changes the preferences by replacing the old (retrieve) progress dialogue options by two simple check boxes for enabling the send and receive progress, respectively.  As a side effect, we get rid of a bunch of global variables used for the POP3 progress communication between the main and retrieval threads which is a lot cleaner IMHO.

BTW, the patch removes the (now obsolete) file src/threads.h.  I noticed that the file libbalsa/gforest.c is not referenced everywhere – couldn't we remove it?

As always, any comment is welcome!

Cheers,
Albrecht.

---
Patch details:
* libbalsa/libbalsa-marshal.list, libbalsa/mailbox.[ch]: new simplified signature for the mailbox '' signal and the related helper libbalsa_mailbox_progress_notify()
* libbalsa/libbalsa-progress.[ch]: heavy re-factoring of the progress dialogue, including a fully thread-safe interface, simplified access functions, and a new activity mode
* libbalsa/mailbox_pop3.c, libbalsa/send.[ch]: use new progress dialogue interface, pass option to disable send progress dialogue
* src/balsa-app.[ch]: define and initialise enable progress dialogue settings, use changed send function signature
* src/balsa-message.c, src/balsa-mime-widget-message.c, src/balsa-mime-widget-vcalendar.c, src/sendmsg-window.c: use changed send function signature
* src/main-window.[ch]: implement multi-threaded POP3 retrieval, remove old progress implementation, use changed send function signature, replace two-state enum by bool
* src/main.c: remove old progress implementation stuff
* src/pref-manager.c: replace progress dialogue settings by two new bool values and related check boxes
* src/save-restore.c: save/restore new progress dialogue bool values
* src/threads.h: completely remove the file

_______________________________________________
balsa-list mailing list
[email protected]
https://mail.gnome.org/mailman/listinfo/balsa-list
pop3_threads.diff.bz2 (application/x-bzip, 16.2 KB) - not displayed
signature.asc (application/pgp-signature, 473 B)
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAABCAAGBQJaTPKKAAoJEEypbw5n59n483EH/RcjBY8A6gUqRHslEcQEqI7M
r1Z5cDd+dzyL/S0wJmWFRl9Qb7bQkHYAmsGen67Dx31u33G9AmQhBzQOpgMllOvP
7Si5loQM/MmhCwcGzKOBBW9394TFwP48muCkajunZSCw6ziNpoK97HPEYvmuXmYS
O1vCHQqyQxuzU6+9FK255NjgWIiPDADB/2v6VLYTq+JfYIBSugB0g3XVA+RpQLPB
ELjCx0a4O8bz+JMiuGAdIhr6qcRURnwfi7zbZyQ//awGmMVMDDs54JMJtkV0aa3c
djXezpsmbnKa+4V8NGa7gGRWb5ra3n5ef4epXfRCmb6wO6piMbYqMXPPo4jALlc=
=BbL7
-----END PGP SIGNATURE-----
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.