Re: [Patch] LDAP address book: use all email attributes

Hi Albrecht:

On 01/29/2019 03:34:49 PM Tue, Albrecht Dreß wrote:
> Hi all,
> 
> I use Balsa at work with an OpenLDAP server, containing all users of the organisation.  Not sure if this is standard, but they may have multiple LDAP “mail” attributes.  However, Balsa's LDAP address book uses the first mail attribute returned by the server only.
> 
> The attached simple patch add the following changes to libbalsa/address-book-ldap.c:
> - libbalsa_address_book_ldap_get_address(): assign the GList of all mail attribute strings to LibBalsaAddress instead of the first one only;
> - lbabl_get_internet_address(): append separate InternetAddress to a GList instead on returning the first one only.
> 
> I must admit that this is a quick hack, added this afternoon, but it works perfectly for me…
> 
> Opinions?

Thanks for the patch!

Looks good to me--presumably, the motivation for including multiple MAIL attributes is to make all the addresses available☺

Committed to master and pushed to GitLab. The remove-app-menu branch has also been rebased to include the patch, and pushed to GitLab.

> Cheers,
> Albrecht.

_______________________________________________
balsa-list mailing list
[email protected]
https://mail.gnome.org/mailman/listinfo/balsa-list

-----BEGIN PGP SIGNATURE-----

iF0EABECAB0WIQS030wPRfNNA5alz3MfX9S1uSp09QUCXFG66gAKCRAfX9S1uSp0
9aJ+AJ9MPAE/EGvLLe5/bOv6Th0uxbs0CgCfTMGc5dfzweceP9xCvm7qAT98Vdk=
=2MU/
-----END PGP SIGNATURE-----