[Patch] Fix maildir config crash

Albrecht Dreß <[email protected]> Thu, 21 Mar 2019 21:32:55 +0100

Newsgroups	gmane.comp.gnome.apps.balsa
Message-ID	<[email protected]>

Hi all,

I noticed that /sometimes/ closing the config dialogue of an existing maildir mailbox segfaults.  It appears that this is caused by an uninitialised file chooser (I modified the particular code snippet a while ago…).  I am quite sure I tested the changes, including maildir (the format I typically use), no idea why this slipped through, sorry!

Rolling back to the original seems to fix the issue (attached).

Cheers,
Albrecht.

_______________________________________________
balsa-list mailing list
[email protected]
https://mail.gnome.org/mailman/listinfo/balsa-list

fix-maildir-cfg-crash.diff (text/x-patch, 884 B)

diff --git a/src/mailbox-conf.c b/src/mailbox-conf.c
index e491833ec..79cba5898 100644
--- a/src/mailbox-conf.c
+++ b/src/mailbox-conf.c
@@ -735,11 +735,9 @@ create_local_mailbox_dialog(MailboxConfWindow *mcw)
 		const gchar *path = libbalsa_mailbox_local_get_path(LIBBALSA_MAILBOX_LOCAL(mcw->mailbox));
 		gchar *basename = g_path_get_basename(path);
 
-		//gtk_file_chooser_set_filename(GTK_FILE_CHOOSER(dialog), path);
-		//gtk_file_chooser_set_current_name(GTK_FILE_CHOOSER(dialog), basename);
-		gtk_file_chooser_set_uri(GTK_FILE_CHOOSER(dialog), mcw->mailbox->url);
+		gtk_file_chooser_set_filename(GTK_FILE_CHOOSER(dialog), path);
+		gtk_file_chooser_set_current_name(GTK_FILE_CHOOSER(dialog), basename);
 		g_free(basename);
-		// FIXME - not optimal
     } else {
         gtk_file_chooser_set_current_folder(GTK_FILE_CHOOSER(dialog), balsa_app.local_mail_directory);
     }

signature.asc (application/pgp-signature, 488 B)