[Patch] fix format string error

Albrecht Dreß <[email protected]> Sun, 09 Jun 2019 18:57:16 +0200

Newsgroups	gmane.comp.gnome.apps.balsa
Message-ID	<[email protected]>

Hi all,

attached is a tiny patch fixing a “format not a string literal and no format arguments” error (using gcc w/ -Werror=format-security).

Best,
Albrecht.

_______________________________________________
balsa-list mailing list
[email protected]
https://mail.gnome.org/mailman/listinfo/balsa-list

fix-format-string-error.diff (text/x-patch, 527 B)

diff --git a/src/sendmsg-window.c b/src/sendmsg-window.c
index f392deedd..b62ee4e8b 100644
--- a/src/sendmsg-window.c
+++ b/src/sendmsg-window.c
@@ -3777,7 +3777,7 @@ sw_insert_sig_activated(GSimpleAction * action,
     } else if (error != NULL) {
         balsa_information_parented(GTK_WINDOW(bsmsg->window),
                                    LIBBALSA_INFORMATION_ERROR,
-                                   error->message);
+                                   "%s", error->message);
         g_error_free(error);
     }
 }

signature.asc (application/pgp-signature, 488 B)