[Patch] Fix handling of Multipart/Related

Albrecht Dreß <[email protected]> Sun, 17 Nov 2019 16:54:42 +0100
Newsgroups gmane.comp.gnome.apps.balsa
Message-ID <[email protected]>
Hi all,

attached is a patch fixing three issues in the handling of multipart/related parts, typically used with inlined images for HTML messages:

(1) printing such a message just hangs, as I (shame on me) forgot to pass the body to the webkit callbacks;
(2) printing does not consider multipart/related at all, resulting in (after fixing #1 above) in a printout with the hatml body *and* all inlined images again;
(3) whilst typically the first child of a multipart/related is the “root” object, RFC 2387 Sect 3.2 defines a mechanism to use a different child.  Balsa ignores this parameter, and does not display such messages correctly.

The attached patch fixes both issues.

Comments?

Cheers,
Albrecht.

---
Patch details:
- libbalsa/body.[ch]: implement a new helper function libbalsa_message_body_mp_related_root() returning the root object of a multipart/related;
- libbalsa/html.c: pass the HTML body to the Webkit callbacks when printing;
- src/balsa-message.c: use the new helper for fetching the multipart/related root object;
- src/print-gtk.c: properly handle multipart/related

_______________________________________________
balsa-list mailing list
[email protected]
https://mail.gnome.org/mailman/listinfo/balsa-list
fix-mp-related.diff.gz (application/gzip, 1.7 KB) - not displayed
signature.asc (application/pgp-signature, 488 B)
-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEcCEPemLFTtyGf4zATKlvDmfn2fgFAl3RbUIACgkQTKlvDmfn
2fihwggAq1822S14bYFgC4h2ePdGvOuzFfL1wJ4uG7vhSNvOmoJGfe4TGJ2DR4kA
wdP9MiV44EplwCgUMx6AgFORk43q6UlD3Z7wzGc8jA2Z1WTp4HSn0i5auXWyD7f/
JvNib/d7ha/zYdgVuTCD/2Myfoj4nipx62NQjWhhwAbIRIoNUIsvKdwapecgtrPL
ObBxBW8kv2MyQ9u016Fpr5SuwZpEFJiaKZyN3W1FCZauwuW4PoXMvU0FqMI4Yq0l
Iav1YEXG46Vwf+mOM5wtAle3E3C/svstRKRSoH5aaP1/P8NeI2ZL3jN7QeyERhzS
7Z5rrC4i0vdLacvnGBUiI5y3sBWV1Q==
=jnmA
-----END PGP SIGNATURE-----