Re: [Patch] Bug fix: S/MIME cert chain broken in identity key selection
Peter Bloomfield <[email protected]> Thu, 23 Jan 2020 15:19:31 -0500
| Newsgroups | gmane.comp.gnome.apps.balsa |
|---|---|
| Message-ID | <[email protected]> |
On 01/22/2020 01:45:33 PM Wed, Albrecht Dreß wrote: > Hi all, > > I noticed that Balsa throws a CRITICAL when I try to view the certification chain of a S/MIME certificate selected in the Identity dialogue. The reason: the fingerprint is not passed to function libbalsa_gpgme_key(). However, this parameter is reserved for the fingerprint of a signature's subkey. > > The simple solution: if the passed fingerprint is NULL, use the one of the first subkey. If that one is /still/ NULL, display a message about a probably broken key instead of throwing the CRITICAL. > > The attached patch is suitable for both the master and gmime3 branches. > > Opinions? Thanks for the patch--looks good! Peter _______________________________________________ balsa-list mailing list [email protected] https://mail.gnome.org/mailman/listinfo/balsa-list
signature.asc
(application/pgp-signature, 195 B)
-----BEGIN PGP SIGNATURE----- iF0EABECAB0WIQS030wPRfNNA5alz3MfX9S1uSp09QUCXin/0wAKCRAfX9S1uSp0 9ZR6AJ0RPmPzwJQBPHiRQNse+cpzZddlWACfa6X7x3VRTZZ3pXLMlKghdOos1As= =uhoi -----END PGP SIGNATURE-----