Re: [Patch] unify wrapped label creation
Peter Bloomfield <[email protected]> Mon, 27 Jan 2020 16:00:44 -0500
| Newsgroups | gmane.comp.gnome.apps.balsa |
|---|---|
| Message-ID | <[email protected]> |
On 01/27/2020 03:43:26 PM Mon, Albrecht Dreß wrote: > Am 27.01.20 21:38 schrieb(en) Albrecht Dreß: >>> If I'm right (and I recognize a substantial probability that I'm wrong!-), we should just use the "xalign" property to make sure that the text is flush left (or occasionally flush right) in the space allocated to the widget. >>> >>> Does that make any sense? >> >> Yes, you're right, it does… Actually it's easy to fix with the patch – just remove line 934 “gtk_widget_set_halign(label, GTK_ALIGN_START);” in misc.c! > > …or do not apply the patch, and everywhere where it would be used (i.e. libbalsa_create_wrap_label() would be called) add the xalign property. I think the code simplification (one statement compared to three or four) outweighs the extra overhead (the call plus the bool compare), though. > > Cheers, > Albrecht. I'll go for changing one line! Will push shortly… Best, Peter _______________________________________________ balsa-list mailing list [email protected] https://mail.gnome.org/mailman/listinfo/balsa-list
signature.asc
(application/pgp-signature, 195 B)
-----BEGIN PGP SIGNATURE----- iF0EABECAB0WIQS030wPRfNNA5alz3MfX9S1uSp09QUCXi9PfAAKCRAfX9S1uSp0 9YIfAJ9zkvdnbdCDFskwwGukOagTZDWPYgCdHAXZvCVrt2Jw8hymU0yedYKdZVU= =AFtv -----END PGP SIGNATURE-----