Re: Compile error

--===============0447720670312622993==
Content-Type: multipart/signed; micalg=PGP-SHA512;
	protocol="application/pgp-signature"; boundary="=-0Tn1l6AHl11LLeEi6MvC"

--=-0Tn1l6AHl11LLeEi6MvC
Content-Type: text/plain; charset=UTF-8; DelSp=Yes; Format=Flowed
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi Andreas,

thanks a lot for your report!

Am 14.03.22 13:52 schrieb(en) AS via balsa-list:
> 	mailbox_imap.c: In function =E2=80=98libbalsa_mailbox_imap_fetch_headers=
=E2=80=99:
> 	mailbox_imap.c:2333:15: error: comparison of integer expressions of diff=
erent signedness: =E2=80=98glong=E2=80=99 {aka =E2=80=98long int=E2=80=99} =
and =E2=80=98unsigned int=E2=80=99 [-Werror=3Dsign-compare]
> 	 2333 |     if (msgno > imap_mbox_handle_get_exists(mimap->handle))
> 		        |               ^
> 	cc1: all warnings being treated as errors

Yes, that's a bug in the code!  Which probably slipped through with older c=
ompilers than on Debian unstable=E2=80=A6

I'm not really familiar with the IMAP code, but I *think* the trivial solut=
ion would be to declare msgno as unsigned in line 2328, and to add a cast t=
o unsigned in line 2330, as all the imap_* functions use unsigned as parame=
ters.  Peter?

Best,
Albrecht.
--=-0Tn1l6AHl11LLeEi6MvC
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEcCEPemLFTtyGf4zATKlvDmfn2fgFAmIvrAoACgkQTKlvDmfn
2fgkyAgAhG3rKKxAeirHAEo0xtey/TUSfN+scf1WUDlqnIJIrPphVc01abEN8JyZ
PMe7Wehug1ZfZQRxssPAHeVLV3V8vA7CL8MA/v2ackHyjIlEL9xfwRfu8N0Yf/fY
Quppda+zTZtUpDp4PYSl5uzjtwkxhwHQRtLidH1l/wWm8vrK+mhb57rGuE/ZXr7f
hgRcZEQNjslN7IbI0Ud3DF3P9syFTkE5E6dzSlMErgFLkm8+kKgWNPz5q+VP53UI
1zTiGZDyuV0AkmvucWimrcro+rX6htm+oSNVu4FdMz6KAVRpkkC8cXQ8+aYWP+jb
Ofx2R82VLxTijS1/Rfi3fQjL5iO0HQ==
=WXMO
-----END PGP SIGNATURE-----

--=-0Tn1l6AHl11LLeEi6MvC--

--===============0447720670312622993==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
balsa-list mailing list
[email protected]
https://mail.gnome.org/mailman/listinfo/balsa-list

--===============0447720670312622993==--