Re: SMP per-CPU statistics under FreeBSD.

On Tue, Apr 25, 2006 at 05:31:34PM +0900, Hajimu UMEMOTO wrote:
> Hi,
> 
> >>>>> On Sun, 23 Apr 2006 01:10:00 +0000
> >>>>> Marco van Tol <[email protected]> said:
> 
> > > 2) You have the choice of reporting composite CPU data yourself or letting gkrellm
> > > calculate the composite data.  Just never call gkrellm_cpu_assign_composite_data()
> > > and gkrellm will do it for you.
> 
> The netbsd.c calls gkrellm_cpu_assign_composite_data().  As far as I
> looked the jhb's patch briefly, it seems kern.cp_time returns
> composite values.  I'm not sure which is better to call
> gkrellm_cpu_assign_composite_data() or not, but I attches the patch to
> call gkrellm_cpu_assign_composite_data().  Sorry but I don't test it
> actually even on single-CPU machine, yet.

That's OK.  Thanks for taking a look, that's already appreciated.

I'm not sure which is better either, but decided to take the lazy path. :)
Thinking about it, it's probably more appropriate to take and feed the
values the kernel thinks are true. 
Approaching it like that, calling gkrellm_cpu_assign_composite_data() is
better.  Thanks.

> Your patch has following line:
> 
> 	+static size_t	oid_pcpu_time_len = sizeof(oid_cp_time);
> 
> It should be:
> 
> 	+static size_t	oid_pcpu_time_len = sizeof(oid_pcpu_time);
> 
> This fix is also inclueded in my patch.

Woops, well spotted, sorry and thanks.

Marco

-- 
Nothing takes the past away like the future
- Madonna in Nothing Really Matters

_______________________________________________
Gkrellm mailing list
[email protected]
http://ninja.linux-phreak.biz/mailman/listinfo/gkrellm