Re: SMP per-CPU statistics under FreeBSD.
Marco van Tol <[email protected]>
| Newsgroups | gmane.comp.gnome.apps.gkrellm |
|---|---|
| Message-ID | <[email protected]> |
On Wed, Apr 26, 2006 at 11:09:28AM +0900, Hajimu UMEMOTO wrote: > Hi, > > >>>>> On Tue, 25 Apr 2006 22:52:47 +0000 > >>>>> Marco van Tol <[email protected]> said: > > marco> I fixed it by putting 'len = sizeof(cp_time);' on line 149, right before > marco> doing the sysctl for oid_pcpu_time, at which point it does indicate the > marco> correct space available in cp_time. This may be crude, and you may want to > marco> fix it more elegantly, but it does fix it. > > Oops, thanks. Your fix is correct. What I also thought off later is that if the sysctl for oid_pcpu_time fails, which will be the case on machines that don't have the pcpu_time patch yet, the code will never call gkrellm_cpu_assign_data(), but only gkrellm_cpu_assign_composite_data(). Not sure if that's a problem, but I think it is. Bill will most likely know. :) In NL it is morning, so good morning by the way. :) Marco -- Most general statements are false, including this one. - Alexander Dumas _______________________________________________ Gkrellm mailing list [email protected] http://ninja.linux-phreak.biz/mailman/listinfo/gkrellm