Did i stumble over a bug ?

Hi everybody!

Today i decided to install the gkrellmd server to my box. Unfortunatetly
not everything is working as expected.

Firstover im running debian 3.1 stable and i'm using version 2.2.5. If
someone can assure me that its fixed in a later version i would be happy
to hear that.

My intention was to run the server to connect via a ssh tunnel only. So i
figured out the config should disallow any hosts to connect except
localhost.

A short glimpse into the config revealed that it was set already set to:

<code>
# List of hosts allowed to connect.  If no hosts are specified in a
# gkrellmd.conf file or on the command line, all hosts will be allowed.
#
allow-host      localhost
allow-host      127.0.0.1
allow-host  ::ffff:127.0.0.1
#allow-host     ::1
#allow-host     192.168.0.*
</code>

So, i just guessed it would be ok but i checked it to be sure. And it
appeared that i could connect to the box from a remote station. Some
checks later i realized thats the numerical ip which causes the trouble.
When i remove the 127.0.0.1 everything works like expected and the remote
machine is rejected.

I supect there might be some bug in the allow_host() function in those lines:

<code>
		if (addr && cidr_match(sa, salen, allowed))
			return TRUE;

		/* Check for simple IPv4 subnet match.  Worry later about ranges and
		|  other hosts_access type patterns.
		*/
		if (   addr
			&& (s = strrchr(allowed, (int) '.')) != NULL
			&& *(s + 1) == '*' && *(s + 2) == '\0'
			&& !strncmp(addr, allowed, (gint) (s - allowed + 1))
		   )
				return TRUE;
</code>

Eigther of the conditions falsely accepts any client when the 127.0.0.1 is
on the list. Sadly, i wasn't able to compile the server on the first run
(think it should be related to missing dependancies) so i couldn't
investigate further.

I hope someone could dig into this and might reveal what gone wrong.

So long...

David


_______________________________________________
Gkrellm mailing list
[email protected]
http://ninja.linux-phreak.biz/mailman/listinfo/gkrellm