Re: [Announce]: gkrellm 2.3.3

On Wed, 30 Dec 2009 11:50:57 +0100
Stefan Gehn <[email protected]> wrote:

> On 22.12.2009 01:47, Bill Wilson wrote:
> >
> > Hi all, I've put up new gkrellm 2.3.3 tarballs:
> >
> nice, I was already feeling guilty for not having worked on the 
> windows-port for about a year.

Yeah, and I was pretty slow to get this release out.  I've been seriously sidetracked
working on getting a house built.

> >      * Patch from Cyrus Rahman: restore gkrellm_sys_main_init() call to proper
> >        place and fix FreeBSD sensors for amd64 and fix allocate sensor bug.
> Unfortunately this breaks logging in gkrellm_sys_main_init() because 
> commandline arguments have not been parsed that early. Furthermore 
> gkrellm_sys_main_init() should never be called in client-mode at all 
> IMHO because all gkrellm_sys_* functions should never be called when in 
> client-mode.
> I guess main() needs a major cleanup/rethinking if we want the order to 
> be right on all platforms and for both client- and server-mode.

We just need to add calls for what the sysdep code needs.  The original
intent for gkrellm_sys_main_init() was to provide for the need for BSD to handle
kmem privileges and that needs to be done early.  So that needs to stay, but
we can add another call to be made after argument parsing and that should let
you set up the way you want.  And this way I can postpone looking at a main()
restructuring that would affect all architectures.

Anyway, for now, I've added a call you can make in gkrellm_sys_main_init()
to register a callback to be called after gkrellm argument parsing.  The callback
is passed the argc and argv so sysdep code can now have sysdep specific
args if needed.

I imagine Windows usage could be something like:

static void win_setup(gint ac, gchar **av)
	{
	/* setup, logging, whatever you did before, etc */
	}

void gkrellm_sys_main_init(void)
	{
	gkrellm_sys_setup_connect(win_setup);
	}

Anyway, I've put up a new tarball which has gkrellm_sys_setup_connect() and
maybe it can be something for you to work with.

Bill

______________________________________________
Gkrellm mailing list
[email protected]
Read archives-join-leave-set RSS feed:
http://archive.lists.netservicesgroup.com
This service is provided by The Network Services Group:
http://www.netservicesgroup.com