Re: Re: Bug#638335: gkrellm: FTBFS(kfreebsd): patch for building on kfreebsd

Heya,

On 08/18/2011 08:34 PM, Sandro Tosi wrote:
> forwarded 638335 [email protected]
> thanks
> 
> Thanks Christoph for teh patch.
> 
> Dear Gkrellm authors, a fellow debian developer has just sent me a
> patch to make gkrellm be buildable again on kfreebsd: it would be nice
> if you can merge it into the upstream source code.
> 
> Sandro

It looks like only the patch parts affecting debian/ ended up on the
gkrellm mailinglist.

Anyway, for the gkrellm list readers, patch is at:
http://bugs.debian.org/cgi-bin/bugreport.cgi?msg=5;filename=gkrellm-kfreebsd.patch;att=1;bug=638335

I don't know much about BSD support in GKrellM but one part of the patch
looks odd to me:


--- gkrellm-2.3.5.orig/src/sysdeps/freebsd.c
+++ gkrellm-2.3.5/src/sysdeps/freebsd.c
@@ -1395,7 +1399,8 @@ static VoltDefault	voltdefault0[] =
 	};

 #include <dirent.h>
-#include <machine/cpufunc.h>
+/*#include <machine/cpufunc.h>*/
+#include <sys/io.h>
 #if __FreeBSD_version >= 500042
 #include <dev/smbus/smb.h>
 #elif __FreeBSD_version >= 300000


Why is the cpufunc.h include commented out? Is it needed for other
systems and if not why not remove the include altogether?

Bye,
Stefan Gehn

______________________________________________
Gkrellm mailing list
[email protected]
Read archives-join-leave-set RSS feed:
http://archive.lists.netservicesgroup.com
This service is provided by The Network Services Group:
http://www.netservicesgroup.com