Re: Error in krell scale for volume sizes in fs,c

Hi Peter,

On 30/07/2018 15:01, Peter Hyman wrote:
> gkrellm krell scale for volume sizes is at 100% in some cases. See graphic.
> This issue appeared after creating some LVM volumes.
> 
> This patch addresses two issues:
> 1. changes long long type to unsigned long long since disk block size is always positive.

This would also need type changes for other variables otherwise you're
comparing values of different signedness which triggers compiler
warnings, hence I've left that out for now.


> 2. corrects fs_>krell_factor when blocks > 2097152

Indeed, the original code before commit
14c4cc4ba0cc717a09b0d9a8390787c5c726e63f used a scale factor of 1024 for
that block size. I restored the correct scale factor now, thanks for the
fix.

Regards,
Stefan