Re: [patch] gqview 2.1 and FUJI raw files (.raf)

Lars Ellenberg wrote:
> 
> resent to gqview-devel ML,
> since there was no reaction to a private mail before...

Sorry, sometimes I am just slow to respond - I did receive the original mail.

> in short:
> 
>   ... so I patched it in.  maybe somewhen this should be in gdk->pixbuf,
>   but for now I just want it in gqview. works for me, happily browses the
>   files created by
>   Fuji Finepix S2 Pro (typical "preview" size is 1440x960)
>   or   Finepix E550 (1600x1200), and probably all other Fuji .raf files.
> 
> details:
> 
> see, I like gqview.
> but now I have these dscf####.raf files,
> and they were just not displayed.
> 
> (not even the thumbnails, even though gimp has created them in the
> standard location. wrong order of "fail check", I guess.)
> 
> quickfix for this particular problem:
> --- gqview-2.1.0/src/thumb_standard.c   2005-03-03 05:09:25.000000000 +0100
> +++ gqview-2.1.0.lge/src/thumb_standard.c       2005-04-26 09:59:05.970224344 +0200
> @@ -709,14 +709,14 @@
>                 {
>                 gint found;
> 
> -               if (thumb_loader_std_fail_check(tl)) return FALSE;
> -
>                 tl->thumb_path = thumb_loader_std_cache_path(tl, FALSE, NULL, FALSE);
>                 tl->thumb_path_local = FALSE;
> 
>                 found = isfile(tl->thumb_path);
>                 if (found && thumb_loader_std_setup(tl, tl->thumb_path)) return TRUE;
> 
> +               if (thumb_loader_std_fail_check(tl)) return FALSE;
> +
>                 return thumb_loader_std_next_source(tl, found);
>                 }

The fail check is first because it tests if the image had previously failed so
that GQview does not attempt to generate a thumbnail again. Instead of the
proposed patch, an option could be added to the maintenance dialog to reset the
fail markers (remove contents of ~/.thumbnails/fail/gqview-1.0).

> ok, of course I know about dcraw and dcparse and gimp plugins and ...
> but.
> 
> thats not what I want here.  all my .raf have a reasonably sized JPEG
> and EXIF data embeded.  I just want gqview to show those, so I can
> easily browse them.
> 
> of course I don't want to just do a quick hack, there are many more
> "raw" file formats out there, and eventually gqview should be able to
> browse all of them (if they have embeded JPEG previews).
> 
> so I created two additional files as framework, src/raw_format_offsets.h
> and src/raw_format_offsets.c, the later containing some stubs and the
> implementation for the fuji .raf format.

I prefer to keep all image formats to stay with using a gdk-pixbuf loader. I
have thought about adding a gqview-extras that installs gdk-pixbuf loaders for
additional (mainly raw) formats for GQview. The problem is that I find no method
is available in GTK+ for an application to add a custom image loader to
gdk-pixbuf at runtime - the only way would be to install the loaders and have
them available to all GTK+ applications. Sounds great until a bug creeps in that
crashes that loader and subsequently all GTK+ apps, and I do not really want to
deal with that.


<wish>
If only all the raw image format hackers could get together and create some sort
of gdk-pixbuf-extras package for file formats not supported by GTK+ proper. The
tedious part would be staying on top of bugs and potential security issues as
they would effect all GTK+ apps (probably why no one has started such a project
up to this point).
</wish>


Greetings,
John


-- 
John Ellis <[email protected]>

http://gqview.sourceforge.net <GQview> | http://hideseek.sourceforge.net
http://gqmpeg.sourceforge.net <GQmpeg> |     <Preferences Hide and Seek>


-------------------------------------------------------
This SF.Net email is sponsored by Oracle Space Sweepstakes
Want to be the first software developer in space?
Enter now for the Oracle Space Sweepstakes!
http://ads.osdn.com/?ad_id=7393&alloc_id=16281&op=click