Re: [patch] gqview 2.1 and FUJI raw files (.raf)

[forwarded to devel list, forgot to include list address in reply]

Lars Ellenberg wrote:
> 
> / 2005-05-14 18:26:27 -0400
> \ John Ellis:
> > > quickfix for this particular problem:
> > > --- gqview-2.1.0/src/thumb_standard.c   2005-03-03 05:09:25.000000000 +0100
> > > +++ gqview-2.1.0.lge/src/thumb_standard.c       2005-04-26 09:59:05.970224344 +0200
> > > @@ -709,14 +709,14 @@
> > >                 {
> > >                 gint found;
> > >
> > > -               if (thumb_loader_std_fail_check(tl)) return FALSE;
> > > -
> > >                 tl->thumb_path = thumb_loader_std_cache_path(tl, FALSE, NULL, FALSE);
> > >                 tl->thumb_path_local = FALSE;
> > >
> > >                 found = isfile(tl->thumb_path);
> > >                 if (found && thumb_loader_std_setup(tl, tl->thumb_path)) return TRUE;
> > >
> > > +               if (thumb_loader_std_fail_check(tl)) return FALSE;
> > > +
> > >                 return thumb_loader_std_next_source(tl, found);
> > >                 }
> >
> > The fail check is first because it tests if the image had previously failed so
> > that GQview does not attempt to generate a thumbnail again. Instead of the
> > proposed patch, an option could be added to the maintenance dialog to reset the
> > fail markers (remove contents of ~/.thumbnails/fail/gqview-1.0).
> 
> current gqview checks its fail markers before it looks for existing
> thumbnails (created by other applications like gimp), and I think that
> is wrong.
> 
> it should first check whether there is a usable thumbnail,
> regardless of whom created it.
> if there is no thumbnail yet, then it should check if _gqview_ failed to
> create one before.  if so, do not attempt to create one, but fail again.
> if there is no gqview specific fail marker, try to create the thumbnail.
> 
> think about it again, that is exactly the reasoning for application
> specific fail markers, but generic thumbnails. and thats what the
> patchlet above does.
> see, only if found == 0 AND thumb_loader_std_fail_check(tl) == FALSE
> thumb_loader_std_next_source is called.

Sorry, after spelling it out to me, you are of course correct. Will be fixed in
next release.

> > > and src/raw_format_offsets.c, the later containing some stubs and the
> > > implementation for the fuji .raf format.
> >
> > I prefer to keep all image formats to stay with using a gdk-pixbuf loader.
> 
> right. but.
> I did not want to mess with a huge project like gtk.
> and it would not help for the exif data, either,
> so you'd have to special-case it in gqview anyways, right?
> unless you use some of the exif sources which already handle raw
> formats, libexif knows about some since december 2004.

For the EXIF parser I do not mind adding support for additional file formats
that also use EXIF. And looking at the way you simply point the image loader to
jpeg data embedded within the raw file - I am starting to agree that this is an
acceptable approach.

The only missing element at this point is adding an additional filter to support
the extensions used by the raw file format(s). For Fuji is this always "*.raf"
or are there variants ?


Greetings,
John

-- 
John Ellis <[email protected]>

http://gqview.sourceforge.net <GQview> | http://hideseek.sourceforge.net
http://gqmpeg.sourceforge.net <GQmpeg> |     <Preferences Hide and Seek>


-------------------------------------------------------
This SF.Net email is sponsored by Oracle Space Sweepstakes
Want to be the first software developer in space?
Enter now for the Oracle Space Sweepstakes!
http://ads.osdn.com/?ad_id=7393&alloc_id=16281&op=click