Re: [patch] Pentax raw file suport

John Ellis <[email protected]> Tue, 07 Nov 2006 15:33:07 -0500
Newsgroups gmane.comp.gnome.apps.gqview.devel
Message-ID <[email protected]>
Petr Kovar wrote:
> Hi,
> 
> I am owner of Pentax K100D camera and happy GQview user. Unfortunately
> GQview hasn't support for Pentax raw format (.pef).
> 
> GQview can read Exif data but can not read thumbnails from .pef files.
> I found out that it is possibe to use the same method like for Nikon
> files.
> 
> Patch is included. If you, John, need .pef files for testing I can
> send you some.

1 or 2 .pef files would be nice to test with.

Is this more or less just an exact copy from the nikon code? If so then 
there is no need to duplicate it out to another file (it can always be done 
in the future). Just add the necessary #define to format_nikon.h and use 
the nikon parser function.

from the patch:
> +#define FORMAT_RAW_PENTAX { "pef", \
> +			   FORMAT_RAW_MATCH_MAGIC, 242, "PENTAX Corporation", 18, \
> +			   "Pentax raw", format_pentax_raw }

Until I see an example .pef file, I can't argue whether MAGIC is really 
necessary or if FORMAT_RAW_MATCH_MAKE would work (seeing as it's a TIFF 
file the magic string could move around in different camera models).

Greetings,
John

-- 
John Ellis <[email protected]>

http://gqview.sourceforge.net <GQview> | http://hideseek.sourceforge.net
http://gqmpeg.sourceforge.net <GQmpeg> |     <Preferences Hide and Seek>


-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642