Random slide show preload

Martin Švec <[email protected]> Mon, 22 Jan 2007 19:23:28 +0100
Newsgroups gmane.comp.gnome.apps.gqview.devel
Message-ID <[email protected]>
This is a multi-part message in MIME format.
--------------090408070901070709090301
Content-Type: text/plain; charset=ISO-8859-2; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

there is a small bug in slide show code. If you start slide show in a
directory, with both 'random slide show' and 'preload next image'
options turned on, the preload option has no effect. Looking into the
source, I have found that slideshow_step() handles this particular case
by calling layout_image_set_index(). However, this function knows
nothing about the random order of images and uses the common +1/-1
read-ahead (which is almost always wrong ;-). I include a simple patch
against 2.1.5 that should fix it.

Cordially

Martin Svec


--------------090408070901070709090301
Content-Type: text/x-patch;
 name="ss-random-preload-2.1.5.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="ss-random-preload-2.1.5.patch"

diff -urN gqview-2.1.5/src/slideshow.c gqview-2.1.5-new/src/slideshow.c
--- gqview-2.1.5/src/slideshow.c	2006-11-30 15:19:30.000000000 +0100
+++ gqview-2.1.5-new/src/slideshow.c	2007-01-13 21:02:28.600195686 +0100
@@ -204,7 +204,7 @@
 			}
 		else
 			{
-			layout_image_set_index(ss->layout, row);
+			layout_image_set_path(ss->layout, ss->slide_path);
 			}
 		}
 
@@ -244,7 +244,7 @@
 			info = g_list_nth_data(ss->cd->list, r);
 			if (info) image_prebuffer_set(ss->imd, info->path);
 			}
-		else if (ss->from_selection)
+		else
 			{
 			image_prebuffer_set(ss->imd, layout_list_get_path(ss->layout, r));
 			}


----------
Zlevnujeme domeny CZ, EU a domeny COM, NET, INFO, BIZ, ORG.
Navic ke kazde nove domene EU ziskate webhosting na 1 ROK ZDARMA!
www.czechia.com


--------------090408070901070709090301
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
--------------090408070901070709090301
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Gqview-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/gqview-devel

--------------090408070901070709090301--