Re: Patch to make progressive loading optional

Jon Colverson <[email protected]> Sat, 25 Dec 2004 01:57:54 +0000
Newsgroups gmane.comp.gnome.apps.gqview.devel
Message-ID <[email protected]>
John Ellis wrote:
> I just had another thought that may speed up the progressive loader, GQview
> reads in a file in very small chunks of 512 bytes, if you want to try increasing
> this, search for 512 in image-load.c (this number should really be set by a
> #define). 16k or 32k size chunks may increase the speed a bit.
> 
> There are a few #defines that may also be of interest:
>    IMAGE_LOAD_BUFFER_COUNT
>      effects the number of iterations reading the 512 byte buffer
>      per idle loop
>    IMAGE_THROTTLE_FACTOR
>      the amount buffer iterations above are increased (multiplied) for
>      images over IMAGE_THROTTLE_THRESHOLD bytes

I tried increasing the buffer size and the count and it didn't make a 
measurable difference. Even tried huge values such that the whole image 
would be loaded in one go. I also tried increasing the priority of the 
idle callback to G_PRIORITY_HIGH_IDLE, but that didn't make a difference 
either.

> Yikes, an option that needs a warning.
> 
> Hold down the PageDown key in a folder with many larger images - now try to do
> anything else, this is why I am against such an option.

That's fair enough. Thanks for considering it, anyway. I might put a web 
page up for my patch if I keep using it, but I'll be sure to explain the 
disadvantage.

Merry Christmas (or Happy Holidays).

-- 
Jon


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now. 
http://productguide.itmanagersjournal.com/