Re: [PATCH] Remove unused check in configure.ac

06.05.2017, 19:52, "Yury V. Zaytsev" <[email protected]>:
> On Wed, 19 Apr 2017, Andrey Gursky wrote:
> 
>>  AC_STRUCT_ST_BLOCKS is a leftover from cleanup in 
>> 0ba019a90b3798abae32ba261e72b737dc945615
> 
> I don't understand why you're saying that this macro is unused. It 
> defines
> 
>      HAVE_STRUCT_STAT_ST_BLOCKS
> 
> if struct `stat` contains an `st_blocks` member. This define is 
> currently
> used in branches all over our codebase.
> 
> https://www.gnu.org/savannah-checkouts/gnu/autoconf/manual/autoconf-2.69/html_node/Particular-Structures.html#Particular-Structures

Yes, you're right. Strange, what is the difference between the art of a 
structure member:
- st_blocks:  AC_STRUCT_ST_BLOCKS (not replaced)
- st_blksize: AC_STRUCT_ST_BLKSIZE (replaced) --> 
AC_CHECK_MEMBERS([struct stat.st_blksize])
so that they should be checked in a different way. In the man page they 
are mentioned together:
"Use of the st_blocks and st_blksize fields may be less portable.  (They 
were introduced in BSD.  The interpretation differs between systems, and 
  possibly on a single system when NFS mounts are involved.)"

>>  ---
>>  configure.ac | 1 -
>>  1 file changed, 1 deletion(-)
>> 
>>  diff --git a/configure.ac b/configure.ac
>>  index 387110daf..ac81404f5 100644
>>  --- a/configure.ac
>>  +++ b/configure.ac
>>  @@ -180,7 +180,6 @@ gl_PROMOTED_TYPE_MODE_T
>>  AC_TYPE_PID_T
>>  AC_TYPE_UID_T
>> 
>>  -AC_STRUCT_ST_BLOCKS
>>  AC_CHECK_MEMBERS([struct stat.st_blksize, struct stat.st_rdev, struct 
>> stat.st_mtim])
>>  gl_STAT_SIZE
>> 
>>  --
>>  2.12.2+git20170411
>>  _______________________________________________
>>  mc-devel mailing list
>>  https://mail.gnome.org/mailman/listinfo/mc-devel
> 
> --
> Sincerely yours,
> Yury V. Zaytsev

Regards,
Andrey
_______________________________________________
mc-devel mailing list
https://mail.gnome.org/mailman/listinfo/mc-devel