Re: Help testing release candidate / mc-4.8.32-rc1

--Apple-Mail=_B836E4F5-87F6-435F-97B5-DD99CE4C90FA
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=us-ascii

Hi David,

Thanks for testing! The patch for the deprecation warning is attached. I =
fixed a similar one in aspell, but unfortunately the CI doesn't work =
yet, and I'm compiling on MacOS, so I didn't get the X11 one.

I hope the translators can take a closer look at the translations. Due =
to a lot of code movement, POT has changed quite a bit, but not in terms =
of new strings. So hopefully it's mostly about marking some strings as =
not fuzzy. If this helps, I can wait another week before pulling in the =
updated translations...

All the best,
Yury


--Apple-Mail=_B836E4F5-87F6-435F-97B5-DD99CE4C90FA
Content-Disposition: attachment;
	filename=0001-x11-fix-Wdeprecated-declarations-for-g_module_build_.patch
Content-Type: application/octet-stream;
	x-unix-mode=0644;
	name="0001-x11-fix-Wdeprecated-declarations-for-g_module_build_.patch"
Content-Transfer-Encoding: quoted-printable

=46rom=20125b89961a0d388b75169c99a5574dbfcac47baa=20Mon=20Sep=2017=20=
00:00:00=202001=0AFrom:=20"Yury=20V.=20Zaytsev"=20<[email protected]>=0A=
Date:=20Fri,=209=20Aug=202024=2007:31:04=20+0200=0ASubject:=20[PATCH]=20=
x11:=20fix=20`-Wdeprecated-declarations`=20for=0A=20=
`g_module_build_path`=0AMIME-Version:=201.0=0AContent-Type:=20=
text/plain;=20charset=3DUTF-8=0AContent-Transfer-Encoding:=208bit=0A=0A=
```=0Ax11conn.c:140:5:=20warning:=20'g_module_build_path'=20is=20=
deprecated=20[-Wdeprecated-declarations]=0A=20=20140=20|=20=20=20=20=20=
x11_module_fname=20=3D=20g_module_build_path=20(NULL,=20"X11");=0A=20=20=20=
=20=20=20|=20=20=20=20=20^~~~~~~~~~~~~~~~=0A```=0A=0AReported-by:=20=
David=20Mart=C3=ADn=20<[email protected]>=0ASigned-off-by:=20Yury=20V.=20=
Zaytsev=20<[email protected]>=0A---=0A=20lib/tty/x11conn.c=20|=207=20=
+------=0A=201=20file=20changed,=201=20insertion(+),=206=20deletions(-)=0A=
=0Adiff=20--git=20a/lib/tty/x11conn.c=20b/lib/tty/x11conn.c=0Aindex=20=
cdb60f13f..fb471b90c=20100644=0A---=20a/lib/tty/x11conn.c=0A+++=20=
b/lib/tty/x11conn.c=0A@@=20-129,21=20+129,16=20@@=20static=20gboolean=0A=20=
x11_available=20(void)=0A=20{=0A=20#ifdef=20HAVE_GMODULE=0A-=20=20=20=20=
gchar=20*x11_module_fname;=0A-=0A=20=20=20=20=20if=20(lost_connection)=0A=
=20=20=20=20=20=20=20=20=20return=20FALSE;=0A=20=0A=20=20=20=20=20if=20=
(x11_module=20!=3D=20NULL)=0A=20=20=20=20=20=20=20=20=20return=20TRUE;=0A=
=20=0A-=20=20=20=20x11_module_fname=20=3D=20g_module_build_path=20(NULL,=20=
"X11");=0A-=20=20=20=20x11_module=20=3D=20g_module_open=20=
(x11_module_fname,=20G_MODULE_BIND_LAZY);=0A+=20=20=20=20x11_module=20=3D=20=
g_module_open=20("X11",=20G_MODULE_BIND_LAZY);=0A=20=20=20=20=20if=20=
(x11_module=20=3D=3D=20NULL)=0A=20=20=20=20=20=20=20=20=20x11_module=20=3D=
=20g_module_open=20("libX11.so.6",=20G_MODULE_BIND_LAZY);=0A=20=0A-=20=20=
=20=20g_free=20(x11_module_fname);=0A-=0A=20=20=20=20=20if=20(x11_module=20=
=3D=3D=20NULL)=0A=20=20=20=20=20=20=20=20=20return=20FALSE;=0A=20=0A--=20=
=0A2.39.3=20(Apple=20Git-146)=0A=0A=

--Apple-Mail=_B836E4F5-87F6-435F-97B5-DD99CE4C90FA
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8



> On 8. Aug 2024, at 20:08, David Mart=C3=ADn via mc-devel =
<mc-devel-+hD5IHI5XseWCegYutOAJTiNl0CLU6MPYPYVAmT7z5s@public.gmane.org> wrote:
>=20
> Ubuntu server / kubuntu 24.04LTS recently installed with stock dist =
libraries.
> No compilation errors  and seems to run fine. Just a couple of glib2 =
deprecation warnings:
> Making all in tty
> make[3]: Entering directory '/home/dmartin/git/mc-4.8.32-pre1/lib/tty'
>   CC       color-internal.lo
>   CC       color.lo
>   CC       key.lo
>   CC       keyxdef.lo
>   CC       mouse.lo
>   CC       tty-internal.lo
>   CC       tty.lo
>   CC       win.lo
>   CC       x11conn.lo
> x11conn.c: In function 'x11_available':
> x11conn.c:140:5: warning: 'g_module_build_path' is deprecated =
[-Wdeprecated-declarations]
>   140 |     x11_module_fname =3D g_module_build_path (NULL, "X11");
>       |     ^~~~~~~~~~~~~~~~
> In file included from x11conn.c:37:
> /usr/include/glib-2.0/gmodule.h:142:23: note: declared here
>   142 | gchar*                g_module_build_path    (const gchar  =
*directory,
>       |                       ^~~~~~~~~~~~~~~~~~~
>   CC       color-slang.lo
>   CC       tty-slang.lo
>   CCLD     libmctty.la
> make[3]: Leaving directory '/home/dmartin/git/mc-4.8.32-pre1/lib/tty'
> David
> El 8/8/24 a las 10:51, Yury V. Zaytsev via mc-devel escribi=C3=B3:
>> Hi there,=20
>>=20
>> TLDR; I would appreciate if you could please test the following =
tarball on your systems and report any blocker regressions as compared =
to the previous 4.8.31 release:=20
>>=20
>> https://midnight-commander.org/nopaste/tarball/mc-4.8.32-pre1.tar.xz=20=

>>=20
>> $ sha256sum mc-4.8.32-pre1.tar.xz=20
>> 18b4d195963eaca64b99e1be61060e8f4d5cfc3854abfeb3ca70d3af87f60871=20
>>=20
>> I've built this tarball out of the latest master with translations =
from Transifex pulled in on a fresh Fedora 40 VM, which I'm also going =
to use to build the final release in about a week from now (or earlier) =
if nothing serious comes up.=20
>>=20
>> Many thanks!=20
>>=20
> --=20
> mc-devel mailing list
> mc-devel-+hD5IHI5XseWCegYutOAJTiNl0CLU6MPYPYVAmT7z5s@public.gmane.org
> https://lists.midnight-commander.org/mailman/listinfo/mc-devel


--Apple-Mail=_B836E4F5-87F6-435F-97B5-DD99CE4C90FA
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

-- 
mc-devel mailing list
mc-devel-+hD5IHI5XseWCegYutOAJTiNl0CLU6MPYPYVAmT7z5s@public.gmane.org
https://lists.midnight-commander.org/mailman/listinfo/mc-devel

--Apple-Mail=_B836E4F5-87F6-435F-97B5-DD99CE4C90FA--