Re: IRMC plugin with newer blutooth libs

Hi Marc,

> please review this patch.
> 
> It (hopefully correct) removes the libsdp dependency for irmc with
> bluetoothe support.
> 
> libsdp for linux bluetooth does not exist anymore. Its included in
> the bluez-utils since version 2.7 (AFAIK)

since I am the person who caused this trouble, I should help fixing it.

> so is this configure.in patch ok?

There is a better way to solve this. I don't changed any function names
or any other stuff, I only included everything from bluez-sdp into
bluez-libs. This means if you find sdp_list_free() in libbluetooth you
only need to link againt -lbluetooth. If not you must check for libsdp.

> --- plugins/irmc_sync/configure.in.orig	2004-06-22 01:08:48.000000000 +0200
> +++ plugins/irmc_sync/configure.in	2004-06-22 01:10:41.000000000 +0200
> @@ -23,15 +23,9 @@
>  CPPFLAGS="${PACKAGE_CFLAGS}"
>  AC_CHECK_LIB(bluetooth,baswap,BLUETOOTH=1,BLUETOOTH=0)
>  SDP=0
> -AC_CHECK_LIB(sdp,sdp_list_free,SDP=1,BLUETOOTH=0)
> -AC_MSG_CHECKING(for correct SDP lib version)
> -AC_TRY_COMPILE([
> -#include <bluetooth/sdp.h>
> -#include <bluetooth/sdp_lib.h>
> -],[sdp_record_t t;],AC_MSG_RESULT(yes),BLUETOOTH=0;AC_MSG_RESULT(no))
>  AM_CONDITIONAL(BLUETOOTH,test "${BLUETOOTH}" = "1")
>  if test "x${BLUETOOTH}" = "x0"; then
> -  echo "Bluetooth is DISABLED. You must have bluez-libs and bluez-kernel >= 2.3 and bluez-sdp >= 1.0-pre1."
> +  echo "Bluetooth is DISABLED. You must have bluez-libs and bluez-kernel >= 2.7"
>  fi
>  AC_DEFINE_UNQUOTED(HAVE_BLUETOOTH, ${BLUETOOTH},Defined if Bluetooth is enabled.)
>  LIBS="$LIBS -lglib-2.0"

Please don't talk about bluez-kernel, because this package was
deprecated a long time ago. What you need is a kernel with enabled
RFCOMM support.

Regards

Marcel




-------------------------------------------------------
This SF.Net email sponsored by Black Hat Briefings & Training.
Attend Black Hat Briefings & Training, Las Vegas July 24-29 - 
digital self defense, top technical experts, no vendor pitches, 
unmatched networking opportunities. Visit www.blackhat.com