Re: [PATCH] multisync/src patch

Thanks a lot! I think you forgot the actual patch, but I reconstructed
it from your comments. It's now committed to CVS.

/Bo

On Fri, 2004-02-13 at 14:26, Stefan Behlert wrote:
> Moin,
> 
> a small patch for the src-folder:
> 
> A few warnings deleted, headerfiles included, unused variables removed.
> A few major bugs fixed:
> syncengine.c line 354: The ',' looks like a typo, I assume '&&' is the correct.
> 	Otherwise the comment for the function is plainly wrong.
> 
> syncengine.c line 447: gpointer sync_main(gpointer data) doesn't return a
> 	value. It looks to me that sync_main is only used to create the
> 	threads, and the return-value is never evaluated (I might be wrong
> 	here, please correct me if so), therefore I added a 'return NULL' at
> 	the end of the function. I'm not content with that return-value,
> 	because it is used as return in an error-case in this function, too,
> 	but I'm not sure what makes the most sense to return.
> 
> sync_vtype.c line 314 and 536: parentheses added to make parsing of && and ||
> 	clear for the compiler. Please review if the behaviour is now the
> 	intended one.  My tests say so, but I might be wrong :)
> 
> sync_vtype.c line 216: alarmaction might be used without initialization. I
> 	heavily changed the order of the code and the if-clauses in the
> 	function, please have a close look at it. 
> 	The function sync_vtype_convert() is way too big in my eyes, but that's
> 	another story :)
> 
> gui.c line 1325: parentheses problem if you use '&'. I'm not quite sure here,
> 	but the '&' should be '&&', shouldn't they? I changed both [ok, now the
> 	parentheses aren't needed, but for readability...]}
> 
> callback.s line 39: gboolean on_syncpairwin_delete_event has no return value. I
> 	think changing the return-value to 'void' should have make no troubles
> 
> 
> Well, that doesn't fix all the warnings during compilation - but most of them.
> Patches are  us usual against the cvs-version.
> It's running on my test-machine, but I can't test some of the plugins
> currently, so please review for any sideeffects in the plugins. 
> 
>         ciao,
>           Stefan
-- 
Bo Lincoln <[email protected]>


-------------------------------------------------------
This SF.Net email is sponsored by: IBM Linux Tutorials
Free Linux tutorial presented by Daniel Robbins, President and CEO of
GenToo technologies. Learn everything from fundamentals to system
administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click