oops, it won't compile all the way (Re: ANN : Tabs support for article overview)

Hi,

A few problems building your 'tabs' branch from scratch:

> […]
> Making all in icons
> make[3]: Entering directory `/Volumes/RamDisk/Safari/pan2_ssl_tabs/pan/icons'
> make[3]: *** No rule to make target `icon_close.png', needed by `pan-pixbufs-internal.h'.  Stop.
> make[3]: Leaving directory `/Volumes/RamDisk/Safari/pan2_ssl_tabs/pan/icons'
> make[2]: *** [all-recursive] Error 1
> make[2]: Leaving directory `/Volumes/RamDisk/Safari/pan2_ssl_tabs/pan'
> make[1]: *** [all-recursive] Error 1
> make[1]: Leaving directory `/Volumes/RamDisk/Safari/pan2_ssl_tabs'
> make: *** [all] Error 2
> make: Leaving directory `/Volumes/RamDisk/Safari/pan2_ssl_tabs'
> […]

The repo does not have a file named 'icon_close.png'.
So I commented-out the 'icon_close.png' line in pan/icons/Makefile,
then proceeded onwards, and got possibly a related problem:

> […]
> Making all in gui
> make[3]: Entering directory `/Volumes/RamDisk/Safari/pan2_ssl_tabs/pan/gui'
> […]
> g++-4.2 -DHAVE_CONFIG_H -I. -I../..  -I../.. -D_REENTRANT -I/usr/local/include/gtkspell-2.0 -I/usr/local/include/gtk-2.0 -I/usr/local/lib/gtk-2.0/include -I/usr/local/include/atk-1.0 -I/usr/local/include/pango-1.0 -I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include -I/opt/X11/include/cairo -I/opt/X11/include -I/opt/X11/include/pixman-1 -I/opt/X11/include/freetype2 -I/opt/X11/include/libpng15   -D_REENTRANT -I/usr/local/include/gtk-2.0 -I/usr/local/lib/gtk-2.0/include -I/usr/local/include/atk-1.0 -I/usr/local/include/pango-1.0 -I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include -I/opt/X11/include/cairo -I/opt/X11/include -I/opt/X11/include/pixman-1 -I/opt/X11/include/freetype2 -I/opt/X11/include/libpng15   -D_REENTRANT -I/usr/local/include/gmime-2.6 -I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include   -D_REENTRANT -I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include   -I/usr/local/ssl/include   -DPANLOCALEDIR=\""/usr/local/share/locale"\" -I/usr/local/ssl/include -I/usr/X11/include -I/usr/local/include -I/WhichXcode/Headers/FlatCarbon -I/usr/include   -Os  -mtune=core2 -march=core2  -force_cpusubtype_ALL  -arch i386  -g -MT gui.o -MD -MP -MF .deps/gui.Tpo -c -o gui.o gui.cc
> gui.cc: In member function ‘GtkWidget* pan::GUI::create_notebook_label(const gchar*, GtkWidget*, GtkWidget*, gint, const char*)’:
> gui.cc:1631: error: ‘icon_close’ was not declared in this scope
> make[3]: *** [gui.o] Error 1
> make[3]: Leaving directory `/Volumes/RamDisk/Safari/pan2_ssl_tabs/pan/gui'
> make[2]: *** [all-recursive] Error 1
> make[2]: Leaving directory `/Volumes/RamDisk/Safari/pan2_ssl_tabs/pan'
> make[1]: *** [all-recursive] Error 1
> make[1]: Leaving directory `/Volumes/RamDisk/Safari/pan2_ssl_tabs'
> make: *** [all] Error 2
> make: Leaving directory `/Volumes/RamDisk/Safari/pan2_ssl_tabs'
> 
> $ _

I don't know what to do at this point?

(
 a general caution for _all_ developers:
 please consider testing your checked-in code from scratch,
 before announcing it
 ;)
)

btw I got your latest master branch compiled with the latest fixes there,
I'm using it now, looks good so far including bitrate value,
but something with the ISP and/or GN keeps lowering our speeds,
I hope "they" are not messing with things
[I better stop there, lest I go into an Alex-Jones-style tirade :D ].


-- 



_______________________________________________
Pan-devel mailing list
[email protected]
https://lists.nongnu.org/mailman/listinfo/pan-devel