The recent git merges broke pan's build for me, culprit 18f92b133

Duncan <[email protected]>
Newsgroups gmane.comp.gnome.apps.pan.user
Message-ID <[email protected]>
Today's pan git pull (from previous git 7771e5655 to new git head 837b6eb1e) failed to build.
Bisecting points to:

commit 18f92b133
Author:     Thomas Tanner <[email protected]>
AuthorDate: Sun Jul 3 19:51:04 2022 +0100
Commit:     Thomas Tanner <[email protected]>
CommitDate: Sun Jul 3 19:51:04 2022 +0100

    deal with a bunch of issues detected by cppcheck


The build error is iconv_t related, in the usenet-utils dir building message-check.cc:

Make[3]: Leaving directory '/tmp/portage/net-nntp/pan-9999/work/pan-9999/pan/general'
Making all in usenet-utils
make[3]: Entering directory '/tmp/portage/net-nntp/pan-9999/work/pan-9999/pan/usenet-utils'

...

In file included from message-check.cc:31:
mime-utils.h:114:10: error: 'iconv_t' does not name a type; did you mean 'lconv'?
114 |   extern iconv_t conv;
    |          ^~~~~~~
    |          lconv
mime-utils.h:117:40: error: 'iconv_t' was not declared in this scope; did you mean 'lconv'?
117 |   static char * __g_mime_iconv_strdup (iconv_t cd, const char *str, const char* charset=0)
    |                                        ^~~~~~~
    |                                        lconv
mime-utils.h:117:52: error: expected primary-expression before 'const'
117 |   static char * __g_mime_iconv_strdup (iconv_t cd, const char *str, const char* charset=0)
    |                                                    ^~~~~
mime-utils.h:117:69: error: expected primary-expression before 'const'
117 |   static char * __g_mime_iconv_strdup (iconv_t cd, const char *str, const char* charset=0)
    |                                                                     ^~~~~
mime-utils.h:117:90: error: expression list treated as compound expression in initializer [-fpermissive]
117 |   static char * __g_mime_iconv_strdup (iconv_t cd, const char *str, const char* charset=0)
    |                                                                                          ^
make[3]: *** [Makefile:448: message-check.o] Error 1

I'm compiling using gcc-12.2.0 on gentoo ~amd64.
Looks like iconv_t is defined by /usr/include/iconv.h, which is from glibc so it's pretty basic.
Today's update did include a glibc update, to glibc-2.35-r10 (a gentoo-revision update
from the previous -r8, seems I skipped -r9), but I did confirm that my previously installed
git 7771e5655 still built against the new glibc, as did the immediately pre-culprit
commit 503708583, so indeed the culprit is 18f92b133.

-- 
Duncan - List replies preferred.   No HTML msgs.
"Every nonfree program has a lord, a master --
and if you use the program, he is your master."  Richard Stallman


_______________________________________________
Pan-users mailing list
[email protected]
https://lists.nongnu.org/mailman/listinfo/pan-users
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.