Merging two functions in mrp-task-manager.c
Maurice van der Pot <griffon26-bCGDfOjggl9Wk0Htik3J/[email protected]>
| Newsgroups | gmane.comp.gnome.apps.planner.devel |
|---|---|
| Message-ID | <[email protected]> |
While working on a fix for some bug I noticed that task_manager_calculate_task_finish and task_manager_calculate_start_from_finish are incredibly similar and that the duplication is causing some problems. Some bugs that are present in both functions are being fixed in only one of them. Also features are sometimes added to one and forgotten in the other. See here for a diff (generated with kdiff3 using manual diff alignments): http://www.kfk4ever.com/~griffon26/shared/plannerdiff.pdf My proposal is to merge these functions into one and adding a parameter to select the behaviour. This may result in some ifs, but I'd rather have that than the current code duplication. Thoughts? Maurice. -- Maurice van der Pot Gentoo Linux Developer [email protected] http://www.gentoo.org Gnome Planner Developer griffon26-bCGDfOjggl9Wk0Htik3J/[email protected] http://live.gnome.org/Planner _______________________________________________ Planner-dev-list mailing list [email protected] http://mail.gnome.org/mailman/listinfo/planner-dev-list
signature.asc
(application/pgp-signature, 189 B)
-----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.7 (GNU/Linux) iD8DBQFHk2s7MGnpIbeahxwRAr41AKCxxOatSKba1pqMS1/3Ov1AnZAreACgzCcE y3qxM49h00I9UDvvlp5ztqA= =CuaP -----END PGP SIGNATURE-----