Re: [PATCH 00/16]fix warning: variable 'priv' set but not used
Alexandre Franke <[email protected]> Thu, 13 Oct 2011 16:27:00 +0200
| Newsgroups | gmane.comp.gnome.apps.planner.devel |
|---|---|
| Message-ID | <CAJ-e=JB0XGuy=t-yLANaRsnb+E5GiTfrh3VR7HAQ7wZ1RLdjXA@mail.gmail.com> |
On Wed, Oct 12, 2011 at 9:30 PM, Tinggong Wang <[email protected]> wrote: > this pactchset fix compile warning: variable 'priv' set but not used. Thank you. However, the way you submitted your fix is hard to work with. The recommended way to do it is to open a bug on bugzilla.gnome.org and attach the patch there. Also, as your modifications are all related to the same problem so one patch for everything is enough, there's no need to have one patch per changed file. Please use git format-patch to generate the patch. Also, it is inappropriate to have all those people as recipients. If you want to discuss Planner development, please use the list and only the list (I'm only CCing them here to let them know your mail has been answered). If you have any question, I'd be more than happy to answer them (on the list). Regards. -- Alexandre Franke