Re: [PATCH 00/16]fix warning: variable 'priv' set but not used

on Thu, 13 Oct 2011 04:27:00PM +0200 Alexandre Franke ([email protected]) wrote:
> On Wed, Oct 12, 2011 at 9:30 PM, Tinggong Wang <[email protected]> wrote:
> > this pactchset fix compile warning: variable 'priv' set but not used.
> 
> Thank you. However, the way you submitted your fix is hard to work with.
> 
> The recommended way to do it is to open a bug on bugzilla.gnome.org
> and attach the patch there. Also, as your modifications are all
> related to the same problem so one patch for everything is enough,
> there's no need to have one patch per changed file. Please use git
> format-patch to generate the patch.
the patches are generated by 'git format-pacth -n --cover-letter 5bde9e6'.

I think they are trivial fixes, and small patches are more easy to review, 
so i follow the rule in this page:
  http://live.gnome.org/Planner/Development

  Submitting patches
    if you make white space changes, keep them in a separate patch. This
    will keep the functionality patch small and readable, while
    the white space patch can be easily verified to be nothing but
    white space changes (diff -w) 

I'll open a bug on bugzilla soon, and attach one patch for this warning.

> 
> Also, it is inappropriate to have all those people as recipients. If
> you want to discuss Planner development, please use the list and only
> the list (I'm only CCing them here to let them know your mail has been
> answered).
I'm sorry for my rude behavior, i am really don't know who should be the
recipient, so i send to the people in AUTHORS.

i got it now, thanks for your help :)

--
Tinggong
2011-10-14

> 
> If you have any question, I'd be more than happy to answer them (on the list).
> 
> Regards.
> 
> -- 
> Alexandre Franke