Re: Fixed: UI freeze when updating tags of many tracks

--===============0449608472844179862==
Content-Type: multipart/alternative; boundary=047d7b5d33ec544b0c05045cf7f9

--047d7b5d33ec544b0c05045cf7f9
Content-Type: text/plain; charset=UTF-8

Ok, I will investigate it further. Last time I found that it had something
to do with (what seemed like a possibly redundant) test that used DBus.

On Wed, Oct 1, 2014 at 4:02 PM, Jonathan Matthew <[email protected]> wrote:

> On Tue, Sep 30, 2014 at 09:33:11AM +0300, Yam Marcovic wrote:
> > Right, thanks!
> >
> > Here's the rebased branch. I made it into 2 commits: one affecting
> RhythmDB
> > (which is essentially independent of the other) and the second using the
> > new DB features to make an async commit.
> > https://github.com/ymarcov/rhythmbox/commits/sync_multiple_songs_async
> >
> > Attaching the patch to bugzilla - noted. If possible, I'd still
> appreciate
> > a basic review just to make sure I didn't do anything too weird.
>
> I think you should find out what's actually taking so long in the commit
> process
> and fix that.  I really don't want to add more threads to rhythmdb.
>
>


-- 
Yam Marcovic

--047d7b5d33ec544b0c05045cf7f9
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div class=3D"gmail_default" style=3D"font-family:verdana,=
sans-serif;color:rgb(0,0,0)">Ok, I will investigate it further. Last time I=
 found that it had something to do with (what seemed like a possibly redund=
ant) test that used DBus.<br></div></div><div class=3D"gmail_extra"><br><di=
v class=3D"gmail_quote">On Wed, Oct 1, 2014 at 4:02 PM, Jonathan Matthew <s=
pan dir=3D"ltr">&lt;<a href=3D"mailto:[email protected]" target=3D"_blank">=
[email protected]</a>&gt;</span> wrote:<br><blockquote class=3D"gmail_quote=
" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><=
span class=3D"">On Tue, Sep 30, 2014 at 09:33:11AM +0300, Yam Marcovic wrot=
e:<br>
&gt; Right, thanks!<br>
&gt;<br>
&gt; Here&#39;s the rebased branch. I made it into 2 commits: one affecting=
 RhythmDB<br>
&gt; (which is essentially independent of the other) and the second using t=
he<br>
&gt; new DB features to make an async commit.<br>
&gt; <a href=3D"https://github.com/ymarcov/rhythmbox/commits/sync_multiple_=
songs_async" target=3D"_blank">https://github.com/ymarcov/rhythmbox/commits=
/sync_multiple_songs_async</a><br>
&gt;<br>
&gt; Attaching the patch to bugzilla - noted. If possible, I&#39;d still ap=
preciate<br>
&gt; a basic review just to make sure I didn&#39;t do anything too weird.<b=
r>
<br>
</span>I think you should find out what&#39;s actually taking so long in th=
e commit process<br>
and fix that.=C2=A0 I really don&#39;t want to add more threads to rhythmdb=
.<br>
<br>
</blockquote></div><br><br clear=3D"all"><br>-- <br><div dir=3D"ltr">Yam Ma=
rcovic<br></div>
</div>

--047d7b5d33ec544b0c05045cf7f9--

--===============0449608472844179862==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
rhythmbox-devel mailing list
[email protected]
https://mail.gnome.org/mailman/listinfo/rhythmbox-devel

--===============0449608472844179862==--