Re: GTK_MODULE (G)Option breakage & init ordering ...
michael meeks <[email protected]> Tue, 07 Feb 2006 14:58:21 +0000
| Newsgroups | gmane.comp.gnome.gtk+.devel.general,gmane.comp.gnome.components,gmane.comp.gnome.accessibility.devel |
|---|---|
| Organization | Novell, Inc. |
| Message-ID | <[email protected]> |
On Tue, 2006-02-07 at 09:24 -0500, Matthias Clasen wrote: > > Unfortunately - the introduction of GOption clobbered all GtkModule > > argument passing; and ensures that no GtkModule gets anything but a > > 0/NULL argc/argv cf. > > Looks like this is a bug that got introduced when we first switched to > GOption, and never discovered. Surprising that nobody noticed it before. Right ;-) of course, there could be a 3rd bug somewhere that's revealing this suddenly. > I'll look into it, we may just have to do the argv-duping earlier. Well - IMHO it'd be better to re-work that -slightly- to dlopen the gtk_modules earlier (since that has to be done anyway) and hooking some GOption info out of them - so they can have a crack at parsing the args themselves [ no idea if that'll work though ;-) perhaps a double parse is necessary to get the --gtk-modules= flag out first ]. That'd IMHO add a clean / generic way to allow modules to register arguments I suppose. Either way - the libbonobo fix for this wrt. accumulating arguments as they are passed in is quite simple & fairly clean, and committed ;-) Thanks anyhow, Michael. -- [email protected] <><, Pseudo Engineer, itinerant idiot