Re: [PATCH]: Workaround cpp bug with orbit-2-idl in non C locale

Hi Fernando,

On Thu, 2003-06-12 at 00:59, [email protected] wrote:
> 	Hi. Here is a fix for building ORBit-2 and libbonobo in non-C locales.

	Great ! :-) it's wonderful to have you working on this.

> 	I will ask the gcc people about this, but anyway, to make ORBit-2 
> and libbonoboui buildable under a non-C locale, here are two patches for 
> Makefile.am and Makefile.shared that only do LC_ALL="" before invoking
> orbit-idl-2. 

	It seems to be a gcc bug; it'd be great to have it fixed there.

> 	I think this will make GNOME more buildable for Spanish users (gcc is
> translated to few languages :) that now was removing .deps by hand, or running
> jhbuild with C locale. Ok to commit?

	The approach is fine; I'd prefer a smaller patch nearer the problem -
if something like this works [ or sim. in orbit-idl ] can you commit
that instead ?

	Thanks,

		Michael,

Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/libIDL/ChangeLog,v
retrieving revision 1.151
diff -u -p -u -r1.151 ChangeLog
--- ChangeLog 26 May 2003 17:18:30 -0000 1.151
+++ ChangeLog 12 Jun 2003 10:15:15 -0000
@@ -1,3 +1,7 @@
+2003-06-12  Fernando Herrera de las Heras  <[email protected]>
+
+       * util.c (IDL_parse_filename): clobber LC_ALL
+
 2003-05-26  Mark McLoughlin  <[email protected]>
 
        * configure.in: Version 0.8.2.
Index: util.c
===================================================================
RCS file: /cvs/gnome/libIDL/util.c,v
retrieving revision 1.129
diff -u -p -u -r1.129 util.c
--- util.c   28 Apr 2003 12:07:37 -0000 1.129
+++ util.c   12 Jun 2003 10:15:17 -0000
@@ -328,6 +328,10 @@ int IDL_parse_filename (const char *file
                 cwd, cpp_args ? cpp_args : "", tmpfilename, cpperrs);
 #endif
 
+       /* Many versions of gpp do evil translating internal
+        * strings, producing bogus output, so clobber LC_ALL */
+       putenv ("LC_ALL=C");
+
 #ifdef HAVE_POPEN
        input = popen (cmd, "r");
 #else


-- 
 [email protected]  <><, Pseudo Engineer, itinerant idiot