Re: [gnome-db] IMPACTED_ROWS

On 24 March 2011 08:00, Piotr Pokora <[email protected]> wrote:
> Hi!
>
>>> If database provides MATCHED_ROW, set it.
>>> If not, set it using IMPACTED_ROW value.
>>
>> The IMPACTED_ROW value should always be there (I don't want any "API
>> break").
>> So I propose to modify the call to mysql_real_connect() to use the
>> CLIENT_FOUND_ROWS flag which has the effect that the
>> mysql_affected_rows() function returns the number of matched rows
>> instead of the number of the number of modified rows. This way the
>> IMPACTED_ROW will be like for any other provider.
>>
>> Is this Ok for you?
>
> Sounds very good, yes.
>
>> For 4.2.x and 5.x or only for 5.x? If it is considered a correction
>> then it's for both, otherwise it's only for 5.x. I'd prefer that it be
>> for 4.2.x and 5.x.
>
> Yeah, using CLIENT_FOUND_ROWS is fine for 4.2 and 5.
>

Ok, I'll do this then.

Regards,

Vivien