Re: [gnome-db] [PATCH] support for inner queries alias without the `AS`.
Vivien Malerba <[email protected]> Sat, 6 Feb 2016 16:13:38 +0100
| Newsgroups | gmane.comp.gnome.db |
|---|---|
| Message-ID | <CAEP1ZNnG8tQCDALrSUq0wscFak0TZXHyMXV5bC0vxnusWRJoeQ@mail.gmail.com> |
--===============1943794259045085188== Content-Type: multipart/alternative; boundary=001a1140714088f6f9052b1b69eb --001a1140714088f6f9052b1b69eb Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Patch committed! Thanks for that correction! Regards, Vivien 2016-02-04 4:08 GMT+01:00 Arthur Neves <[email protected]>: > Thanks Daniel, > > I created an issue, and submitted the patch file there too > https://bugzilla.gnome.org/show_bug.cgi?id=3D761529 > > Vivien, let me know what you think. > > cheers, > > On Wed, Feb 3, 2016 at 6:48 PM Daniel Espinosa <[email protected]> wrote: > >> May be for Vivien this is Ok. >> >> But may you want to know when your patch is accepted or reviewed. If so >> ma is better if you file a bug in bugzilla.gnome.org >> El feb. 3, 2016 3:39 PM, "Arthur Neves" <[email protected]> escribi=C3= =B3: >> >>> Hi folks, >>> >>> I am using libgda to parse all queries on my app, however I saw that >>> sub-queries that had an alias were not working, for instance: >>> >>> SELECT foo.abc FROM (select abc from bar) foo; >>> >>> See this is valid on sqlite3: >>> >>> sqlite> create table bar(abc varchar(10)); >>> sqlite> insert into bar values('hi'); >>> sqlite> SELECT foo.abc FROM (select abc from bar) foo; >>> hi >>> >>> Seems like that syntax was not handled by the parser.y lemon file. So I >>> have a patch for it: >>> >>> https://github.com/arthurnn/libgda/commit/0ba0e8f49f90304256e4fca637928= d8cad55a1e0 >>> >>> Let me know what is the proper way to contribute to this library, if >>> sending a Pull Request on GitHub, or sending a .patch file on the maili= ng >>> list. >>> >>> Let me know if this makes sense >>> >>> Thanks a lot >>> >>> >>> >>> _______________________________________________ >>> gnome-db-list mailing list >>> [email protected] >>> https://mail.gnome.org/mailman/listinfo/gnome-db-list >>> >>> > _______________________________________________ > gnome-db-list mailing list > [email protected] > https://mail.gnome.org/mailman/listinfo/gnome-db-list > > --001a1140714088f6f9052b1b69eb Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div class=3D"gmail_default" style=3D"font-family:arial,he= lvetica,sans-serif">Patch committed! Thanks for that correction!<br></div><= div class=3D"gmail_default" style=3D"font-family:arial,helvetica,sans-serif= ">Regards,<br></div><div class=3D"gmail_default" style=3D"font-family:arial= ,helvetica,sans-serif">Vivien<br></div></div><div class=3D"gmail_extra"><br= ><div class=3D"gmail_quote">2016-02-04 4:08 GMT+01:00 Arthur Neves <span di= r=3D"ltr"><<a href=3D"mailto:[email protected]" target=3D"_blank">arthu= [email protected]</a>></span>:<br><blockquote class=3D"gmail_quote" style=3D= "margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir=3D= "ltr">Thanks Daniel,<div><br></div><div>I created an issue, and submitted t= he patch file there too=C2=A0<a href=3D"https://bugzilla.gnome.org/show_bug= .cgi?id=3D761529" target=3D"_blank">https://bugzilla.gnome.org/show_bug.cgi= ?id=3D761529</a></div><div><br></div><div>Vivien, let me know what you thin= k.</div><div><br></div><div>cheers,</div></div><div class=3D"HOEnZb"><div c= lass=3D"h5"><br><div class=3D"gmail_quote"><div dir=3D"ltr">On Wed, Feb 3, = 2016 at 6:48 PM Daniel Espinosa <<a href=3D"mailto:[email protected]" tar= get=3D"_blank">[email protected]</a>> wrote:<br></div><blockquote class= =3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padd= ing-left:1ex"><p dir=3D"ltr">May be for Vivien this is Ok.</p> <p dir=3D"ltr">But may you want to know when your patch is accepted or revi= ewed. If so ma is better if you file a bug in <a href=3D"http://bugzilla.gn= ome.org" target=3D"_blank">bugzilla.gnome.org</a></p> <div class=3D"gmail_quote"></div><div class=3D"gmail_quote">El feb. 3, 2016= 3:39 PM, "Arthur Neves" <<a href=3D"mailto:[email protected]= " target=3D"_blank">[email protected]</a>> escribi=C3=B3:<br type=3D"at= tribution"></div><div class=3D"gmail_quote"><blockquote class=3D"gmail_quot= e" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">= <div dir=3D"ltr"><div>Hi folks,</div><div><br></div>I am using libgda to pa= rse all queries on my app, however I saw that sub-queries that had an alias= were not working, for instance:=C2=A0<div><br><div>=C2=A0 SELECT foo.abc F= ROM (select abc from bar) foo;</div><div><br></div><div>See this is valid o= n sqlite3:</div><div><br></div><div><div>sqlite> create table bar(abc va= rchar(10));</div><div>sqlite> insert into bar values('hi');</div= ><div>sqlite> SELECT foo.abc FROM (select abc from bar) foo;</div><div>h= i</div></div><div><br></div><div>Seems like that syntax was not handled by = the parser.y lemon file. So I have a patch for it:=C2=A0</div><div><a href= =3D"https://github.com/arthurnn/libgda/commit/0ba0e8f49f90304256e4fca637928= d8cad55a1e0" target=3D"_blank">https://github.com/arthurnn/libgda/commit/0b= a0e8f49f90304256e4fca637928d8cad55a1e0</a></div><div><br></div><div>Let me = know what is the proper way to contribute to this library, if sending a Pul= l Request on GitHub, or sending a .patch file on the mailing list.</div><di= v><br></div><div>Let me know if this makes sense</div><div><br></div><div>T= hanks a lot</div><div><br></div><div><br></div></div></div> <br></blockquote></div><div class=3D"gmail_quote"><blockquote class=3D"gmai= l_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left= :1ex">_______________________________________________<br> gnome-db-list mailing list<br> <a href=3D"mailto:[email protected]" target=3D"_blank">gnome-db-list@= gnome.org</a><br> <a href=3D"https://mail.gnome.org/mailman/listinfo/gnome-db-list" rel=3D"no= referrer" target=3D"_blank">https://mail.gnome.org/mailman/listinfo/gnome-d= b-list</a><br> <br></blockquote></div> </blockquote></div> </div></div><br>_______________________________________________<br> gnome-db-list mailing list<br> <a href=3D"mailto:[email protected]">[email protected]</a><br> <a href=3D"https://mail.gnome.org/mailman/listinfo/gnome-db-list" rel=3D"no= referrer" target=3D"_blank">https://mail.gnome.org/mailman/listinfo/gnome-d= b-list</a><br> <br></blockquote></div><br></div> --001a1140714088f6f9052b1b69eb-- --===============1943794259045085188== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ gnome-db-list mailing list [email protected] https://mail.gnome.org/mailman/listinfo/gnome-db-list --===============1943794259045085188==--