Re: Discussion about adding icon thumbnails to the file picker

--===============7714182925424510010==
Content-Type: multipart/alternative; boundary="0000000000006a995305b8cad24d"

--0000000000006a995305b8cad24d
Content-Type: text/plain; charset="UTF-8"

On Wed, 13 Jan 2021 at 16:32, <[email protected]> wrote:


> There is an interesting patch mentioned
> https://aur.archlinux.org/packages/gtk3-patched-filechooser-icon-view/
> which I have built and tested. I do not think that this patch is ready
> to merge but it is a good start and the code may be useful to somebody
> working on implementing this feature.
>

That patch is, quite emphatically, *not* a good start. It was rejected for
a reason.

Anyway I am interested in what any GNOME developers think about this
> particular feature request.
>
> * Would a high quality pull request that implements this feature be
> accepted?
>

Have you read the issue you linked? There's a whole discussion about this
feature, what the requirements for its inclusion are, and what GTK
developers expect from anybody working on it.

* If not why not?
>

Not for GTK3, which is feature and API frozen.

If you had read the issue you linked above, you'd have seen that using
GtkIconView has very clear downsides when it comes to showing 1000s of
files. The issues are caused by inherent algorithmic problems in the
IconView widget that cannot be fixed.

In order to provide scalable, reflowing icon grids we had to implement a
whole new set of data containers and widgets in GTK4. Those cannot be
backported to GTK3.

If contributors want to add an icon grid to the file selection dialog in
GTK4, they are more than welcome to work on it.

* Is there any internal work on this feature that is not known outside
> of GNOME?
>

No.


> * Would there be any communication and guidance from the GNOME project
> to outside developers aiming to contribute an implementation of this?


All merge requests will be reviewed.

Ciao,
 Emmanuele.

-- 
https://www.bassi.io
[@] ebassi [@gmail.com]

--0000000000006a995305b8cad24d
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">On Wed, 13 Jan 2021 at 16:32, &lt;rain1@a=
irmail.cc&gt; wrote:<br></div><div class=3D"gmail_quote"><div>=C2=A0</div><=
blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-l=
eft:1px solid rgb(204,204,204);padding-left:1ex">There is an interesting pa=
tch mentioned <br>
<a href=3D"https://aur.archlinux.org/packages/gtk3-patched-filechooser-icon=
-view/" rel=3D"noreferrer" target=3D"_blank">https://aur.archlinux.org/pack=
ages/gtk3-patched-filechooser-icon-view/</a> <br>
which I have built and tested. I do not think that this patch is ready <br>
to merge but it is a good start and the code may be useful to somebody <br>
working on implementing this feature.<br></blockquote><div><br></div><div>T=
hat patch is, quite emphatically, *not* a good start. It was rejected for a=
 reason.<br></div><div> <br></div><blockquote class=3D"gmail_quote" style=
=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding=
-left:1ex">
Anyway I am interested in what any GNOME developers think about this <br>
particular feature request.<br>
<br>
* Would a high quality pull request that implements this feature be <br>
accepted?<br></blockquote><div><br></div><div>Have you read the issue you l=
inked? There&#39;s a whole discussion about this feature, what the requirem=
ents for its inclusion are, and what GTK developers expect from anybody wor=
king on it.<br></div><div><br></div><blockquote class=3D"gmail_quote" style=
=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding=
-left:1ex">
* If not why not?<br></blockquote><div><br></div><div>Not for GTK3, which i=
s feature and API frozen.</div><div><br></div><div>If you had read the issu=
e you linked above, you&#39;d have seen that using GtkIconView has very cle=
ar downsides when it comes to showing 1000s of files. The issues are caused=
 by inherent algorithmic problems in the IconView widget that cannot be fix=
ed.</div><div><br></div><div>In order to provide scalable, reflowing icon g=
rids we had to implement a whole new set of data containers and widgets in =
GTK4. Those cannot be backported to GTK3.<br></div><div><br></div><div>If c=
ontributors want to add an icon grid to the file selection dialog in GTK4, =
they are more than welcome to work on it.<br></div><div><br></div><blockquo=
te class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px =
solid rgb(204,204,204);padding-left:1ex">* Is there any internal work on th=
is feature that is not known outside <br>
of GNOME?<br></blockquote><div><br></div><div>No.<br></div><div>=C2=A0</div=
><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border=
-left:1px solid rgb(204,204,204);padding-left:1ex">
* Would there be any communication and guidance from the GNOME project <br>
to outside developers aiming to contribute an implementation of this?</bloc=
kquote><div><br></div><div>All merge requests will be reviewed.<br></div></=
div><div><br></div><div>Ciao,</div><div>=C2=A0Emmanuele.<br></div><div><br>=
</div>-- <br><div dir=3D"ltr" class=3D"gmail_signature"><a href=3D"https://=
www.bassi.io" target=3D"_blank">https://www.bassi.io</a><br>[@] ebassi [@<a=
 href=3D"http://gmail.com" target=3D"_blank">gmail.com</a>]</div></div>

--0000000000006a995305b8cad24d--

--===============7714182925424510010==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
gnome-devel-list mailing list
[email protected]
https://mail.gnome.org/mailman/listinfo/gnome-devel-list

--===============7714182925424510010==--