Re: exported property accessors and types
"Michael Lawrence" <[email protected]> Tue, 26 Sep 2006 15:19:10 -0500
| Newsgroups | gmane.comp.gnome.devtools.gob.general |
|---|---|
| Message-ID | <[email protected]> |
------=_Part_18861_31617890.1159301950948 Content-Type: multipart/alternative; boundary="----=_Part_18862_343670.1159301950948" ------=_Part_18862_343670.1159301950948 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline The patch is attached. It works for me, but I am not sure if it is the best way to do it. Thanks, Michael On 9/26/06, George <[email protected]> wrote: > > On Thu, Sep 14, 2006 at 08:40:18AM -0500, Michael Lawrence wrote: > > > > Is there a reason why the exported accessor for an OBJECT property uses > > the type GObject * instead of that specified in the object_type argument > > for the property? > > > > The same occurs for BOXED (uses gpointer instead of specific type). > > > > If this is not intended, should I fix this and submit a bug? > > Seems like a bug to me. Feel free to submit a patch to this list (this is > where one submits bugs) > > George > > -- > George <[email protected]> > Life is what happens to you when you're busy making other plans... > -- John Lennon > ------=_Part_18862_343670.1159301950948 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline The patch is attached. It works for me, but I am not sure if it is the best way to do it.<br><br>Thanks,<br>Michael<br><br><div><span class="gmail_quote">On 9/26/06, <b class="gmail_sendername">George</b> <<a href="mailto:[email protected]"> [email protected]</a>> wrote:</span><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">On Thu, Sep 14, 2006 at 08:40:18AM -0500, Michael Lawrence wrote: <br>><br>> Is there a reason why the exported accessor for an OBJECT property uses<br>> the type GObject * instead of that specified in the object_type argument<br>> for the property?<br>><br>> The same occurs for BOXED (uses gpointer instead of specific type). <br>><br>> If this is not intended, should I fix this and submit a bug?<br><br>Seems like a bug to me. Feel free to submit a patch to this list (this is<br>where one submits bugs)<br><br>George<br><br>--<br>George < <a href="mailto:[email protected]">[email protected]</a>><br> Life is what happens to you when you're busy making other plans...<br> -- John Lennon<br></blockquote></div><br> ------=_Part_18862_343670.1159301950948-- ------=_Part_18861_31617890.1159301950948 Content-Type: application/octet-stream; name=gob.patch Content-Transfer-Encoding: base64 X-Attachment-Id: f_eskqfhsc Content-Disposition: attachment; filename="gob.patch" KioqIGdvYjItMi4wLjEzL3NyYy9wYXJzZS55CUZyaSBEZWMgMTYgMTM6MTE6MjAgMjAwNQotLS0g Z29iMi0yLjAuMTMtbmV3L3NyYy9wYXJzZS55CVRodSBTZXAgMTQgMTE6MzQ6MzAgMjAwNgoqKioq KioqKioqKioqKioKKioqIDM2MiwzNzEgKioqKgogIAkJICBpbnQgc2V0X2xpbmVubywKICAJCSAg VHlwZSAqdHlwZSwKICAJCSAgY29uc3QgY2hhciAqZ3RrdHlwZSwKICAJCSAgaW50IGxpbmVubykK ICB7CQogIAlUeXBlICp0aGVfdHlwZTsKISAKICAJaWYgKHR5cGUgIT0gTlVMTCkKICAJCXRoZV90 eXBlID0gKFR5cGUgKilub2RlX2NvcHkgKChOb2RlICopdHlwZSk7CiAgCWVsc2UKLS0tIDM2Miwz NzIgLS0tLQogIAkJICBpbnQgc2V0X2xpbmVubywKICAJCSAgVHlwZSAqdHlwZSwKICAJCSAgY29u c3QgY2hhciAqZ3RrdHlwZSwKKyAgICAgICBjb25zdCBjaGFyICpleHRyYXR5cGUsCiAgCQkgIGlu dCBsaW5lbm8pCiAgewkKICAJVHlwZSAqdGhlX3R5cGU7CiEgICBnY2hhciAqYWN0dWFsX3R5cGU7 CiAgCWlmICh0eXBlICE9IE5VTEwpCiAgCQl0aGVfdHlwZSA9IChUeXBlICopbm9kZV9jb3B5ICgo Tm9kZSAqKXR5cGUpOwogIAllbHNlCioqKioqKioqKioqKioqKgoqKiogMzc3LDM4NyAqKioqCiAg CQlyZXR1cm47CiAgCX0KICAKICAJaWYgKGRvX2dldCkgewogIAkJY2hhciAqZ2V0X2lkID0gZ19z dHJkdXBfcHJpbnRmICgiZ2V0XyVzIiwgdmFyX25hbWUpOwogIAkJR1N0cmluZyAqZ2V0X2NidWYg PSBnX3N0cmluZ19uZXcgKE5VTEwpOwogIAkJTm9kZSAqbm9kZTEgPSBub2RlX25ldyAoVFlQRV9O T0RFLAohIAkJCQkJIm5hbWUiLCB0aGVfdHlwZS0+bmFtZSwKICAJCQkJCSJwb2ludGVyIiwgdGhl X3R5cGUtPnBvaW50ZXIsCiAgCQkJCQkicG9zdGZpeCIsIHRoZV90eXBlLT5wb3N0Zml4LAogIAkJ CQkJTlVMTCk7Ci0tLSAzNzgsMzkwIC0tLS0KICAJCXJldHVybjsKICAJfQogIAorICAgYWN0dWFs X3R5cGUgPSBleHRyYXR5cGUgPyByZW1vdmVfc2VwIChleHRyYXR5cGUpIDogZ19zdHJkdXAgKHRo ZV90eXBlLT5uYW1lKTsKKyAKICAJaWYgKGRvX2dldCkgewogIAkJY2hhciAqZ2V0X2lkID0gZ19z dHJkdXBfcHJpbnRmICgiZ2V0XyVzIiwgdmFyX25hbWUpOwogIAkJR1N0cmluZyAqZ2V0X2NidWYg PSBnX3N0cmluZ19uZXcgKE5VTEwpOwogIAkJTm9kZSAqbm9kZTEgPSBub2RlX25ldyAoVFlQRV9O T0RFLAohIAkJCQkJIm5hbWUiLCBhY3R1YWxfdHlwZSwKICAJCQkJCSJwb2ludGVyIiwgdGhlX3R5 cGUtPnBvaW50ZXIsCiAgCQkJCQkicG9zdGZpeCIsIHRoZV90eXBlLT5wb3N0Zml4LAogIAkJCQkJ TlVMTCk7CioqKioqKioqKioqKioqKgoqKiogMzk1LDQwMSAqKioqCiAgCQkJCSAgImdfb2JqZWN0 X2dldCAoR19PQkpFQ1QgKHNlbGYpLCBcIiVzXCIsICIKICAJCQkJICAiJnZhbCwgTlVMTCk7ICIK ICAJCQkJICAicmV0dXJuIHZhbDtcbiIsCiEgCQkJCSAgdGhlX3R5cGUtPm5hbWUsIAogIAkJCQkg IHRoZV90eXBlLT5wb2ludGVyID8gdGhlX3R5cGUtPnBvaW50ZXIgOiAiIiwKICAJCQkJICB2YXJf bmFtZSk7CiAgCQkKLS0tIDM5OCw0MDQgLS0tLQogIAkJCQkgICJnX29iamVjdF9nZXQgKEdfT0JK RUNUIChzZWxmKSwgXCIlc1wiLCAiCiAgCQkJCSAgIiZ2YWwsIE5VTEwpOyAiCiAgCQkJCSAgInJl dHVybiB2YWw7XG4iLAohIAkJCQkgIGFjdHVhbF90eXBlLCAKICAJCQkJICB0aGVfdHlwZS0+cG9p bnRlciA/IHRoZV90eXBlLT5wb2ludGVyIDogIiIsCiAgCQkJCSAgdmFyX25hbWUpOwogIAkJCioq KioqKioqKioqKioqKgoqKiogNDEzLDQxOSAqKioqCiAgCQljaGFyICpzZXRfaWQgPSBnX3N0cmR1 cF9wcmludGYgKCJzZXRfJXMiLCB2YXJfbmFtZSk7CiAgCQlHU3RyaW5nICpzZXRfY2J1ZiA9IGdf c3RyaW5nX25ldyAoTlVMTCk7CiAgCQlOb2RlICpub2RlMSA9IG5vZGVfbmV3IChUWVBFX05PREUs IAohIAkJCQkJIm5hbWUiLCB0aGVfdHlwZS0+bmFtZSwKICAJCQkJCSJwb2ludGVyIiwgdGhlX3R5 cGUtPnBvaW50ZXIsCiAgCQkJCQkicG9zdGZpeCIsIHRoZV90eXBlLT5wb3N0Zml4LAogIAkJCQkJ TlVMTCk7Ci0tLSA0MTYsNDIyIC0tLS0KICAJCWNoYXIgKnNldF9pZCA9IGdfc3RyZHVwX3ByaW50 ZiAoInNldF8lcyIsIHZhcl9uYW1lKTsKICAJCUdTdHJpbmcgKnNldF9jYnVmID0gZ19zdHJpbmdf bmV3IChOVUxMKTsKICAJCU5vZGUgKm5vZGUxID0gbm9kZV9uZXcgKFRZUEVfTk9ERSwgCiEgCQkJ CQkibmFtZSIsIGFjdHVhbF90eXBlLAogIAkJCQkJInBvaW50ZXIiLCB0aGVfdHlwZS0+cG9pbnRl ciwKICAJCQkJCSJwb3N0Zml4IiwgdGhlX3R5cGUtPnBvc3RmaXgsCiAgCQkJCQlOVUxMKTsKKioq KioqKioqKioqKioqCioqKiA0NDMsNDQ4ICoqKioKLS0tIDQ0Niw0NTIgLS0tLQogIAkJCSAgICAg ICBsaW5lbm8sIEZBTFNFLCBOVUxMKTsKICAJfQogIAorICAgZ19mcmVlIChhY3R1YWxfdHlwZSk7 CiAgCW5vZGVfZnJlZSAoKE5vZGUgKil0aGVfdHlwZSk7CiAgfQogIAoqKioqKioqKioqKioqKioK KioqIDYzOCw2NDMgKioqKgotLS0gNjQyLDY0OCAtLS0tCiAgCQkJCSAgcHJvcC0+c2V0ICE9IE5V TEwsICBwcm9wLT5zZXRfbGluZSwKICAJCQkJICBwcm9wLT5wdHlwZSwKICAJCQkJICBwcm9wLT5n dGt0eXBlLAorICAgICAgICAgICBwcm9wLT5leHRyYV9ndGt0eXBlLAogIAkJCQkgIHByb3AtPmxp bmVfbm8pOwogIAl9IAogIH0KKioqKioqKioqKioqKioqCioqKiAxMDUwLDEwNTUgKioqKgotLS0g MTA1NSwxMDYxIC0tLS0KICAJCQkJCQkgIGFyZy0+c2V0ICE9IE5VTEwsIGFyZy0+c2V0X2xpbmUs CiAgCQkJCQkJICBhcmctPmF0eXBlLAogIAkJCQkJCSAgYXJnLT5ndGt0eXBlLAorICAgICAgICAg ICAgICAgTlVMTCwKICAJCQkJCQkgIGFyZy0+bGluZV9ubyk7CiAgCQkJCWdfZnJlZSAoJDxpZD41 KTsKICAJCQl9IAoqKioqKioqKioqKioqKioKKioqIDExMDUsMTExMCAqKioqCi0tLSAxMTExLDEx MTcgLS0tLQogIAkJCQkJCSAgYXJnLT5zZXQgIT0gTlVMTCwgYXJnLT5zZXRfbGluZSwKICAJCQkJ CQkgIGFyZy0+YXR5cGUsCiAgCQkJCQkJICBhcmctPmd0a3R5cGUsCisgICAgICAgICAgICAgICBO VUxMLAogIAkJCQkJCSAgYXJnLT5saW5lX25vKTsKICAJCQkJZ19mcmVlICgkPGlkPjUpOwogIAkJ CX0gCioqKioqKioqKioqKioqKgoqKiogMTE5MCwxMTk1ICoqKioKLS0tIDExOTcsMTIwMyAtLS0t CiAgCQkJCQkJICBhcmctPnNldCAhPSBOVUxMLCBhcmctPnNldF9saW5lLAogIAkJCQkJCSAgYXJn LT5hdHlwZSwKICAJCQkJCQkgIGFyZy0+Z3RrdHlwZSwKKyAgICAgICAgICAgICAgIE5VTEwsCiAg CQkJCQkJICBhcmctPmxpbmVfbm8pOwogIAkJCQlnX2ZyZWUgKCQ8aWQ+NSk7CiAgCQkJfSAK ------=_Part_18861_31617890.1159301950948 Content-Type: text/plain; charset=us-ascii; name="footer" Content-Transfer-Encoding: 8bit -- to unsubscribe: send mail to [email protected] with "unsubscribe gob-list" in the subject ------=_Part_18861_31617890.1159301950948--