Re: Boxes: UI freeze exception needed

Hi Alexandre,

Thanks for quick reply!

On Thu, Aug 20, 2015 at 6:12 PM, Alexandre Franke
<[email protected]> wrote:
> On Thu, Aug 20, 2015 at 7:07 PM, Zeeshan Ali (Khattak)
> <[email protected]> wrote:
>> Hi,
>
> Hey,
>
>> One of the main things my SoC student, Adrien Plazas has been working
>> on as part of his project was to add a list view to Boxes:
>>
>> https://bugzilla.gnome.org/show_bug.cgi?id=733252
>>
>> since it's a very much in demand feature, I'd like it to be included
>> in 3.18. Hence this email. :)
>> Screenshot is attached to the bug.
>>
>> FWIW, we tried our best to get it finished before freeze but I guess
>> plans are bound to fail when it comes to deadlines.
>
> As far as i18n is concerned, you only need to announce string changes
> currently. Does this feature introduce new strings if it gets
> accepted?

Yes. Diffing the pot files, I see two strings introduced:

-#: ../data/ui/collection-toolbar.ui.h:4 ../data/ui/selection-toolbar.ui.h:2
+#: ../data/ui/collection-toolbar.ui.h:4
+msgid "List view"
+msgstr ""
+
+#: ../data/ui/collection-toolbar.ui.h:5
+msgid "Grid view"
+msgstr ""
+

FWIW, I have marked the patches that can't go without exception as
commit_afterfreeze and rest as commitnow.

-- 
Regards,

Zeeshan Ali (Khattak)
________________________________________
Befriend GNOME: http://www.gnome.org/friends/