Re: Minor UI freeze break for Maps

tis 2017-08-29 klockan 08:39 -0400 skrev Matthias Clasen:
> On Tue, Aug 29, 2017 at 4:48 AM, Marcus Lundblad <[email protected]>
> wrote:
> > Hi!
> > 
> > 
> > 
> > In Maps I'd like to make a couple of last-minute changes (I think
> > 
> > they're quite minor).
> > 
> > 
> > 
> > First: we have some non-modal dialogs (the editing of object in
> > 
> > OpenStreetMap, sign-up to accounts on OpenStreetMap, and exporting
> > the
> > 
> > map view as an image) which are not being placed in some awkward
> > place,
> > 
> >  like upper corner when run under Wayland. So, the change here
> > would be
> > 
> > to make these dialogs modal.
> > 
> > 
> > 
> > Second: currenly we always focus the main search entry on start-up.
> > 
> > This has the effect of always showing the on-screen keyboard on
> > touch
> > 
> > devices with no keyboard attached. The change here would change the
> > 
> > behavior so that typing (excluding keyboard shortcuts, obviously)
> > would
> > 
> > focus (and forward characters) to the main search entry when no
> > other
> > 
> > text entry is "active" (this is more in-line with how other GNOME
> > apps
> > 
> > behave, I'd say).
> > 
> > 
> > 
> > So, I'd like to ask for freeze exceptions for these changes
> 
> Not sure these qualify as UI freeze breaks, really: no screenshot
> would be rendered inaccurate by these changes.
> That being said, seeing the suggested code changes would help in
> judging the risk. 

That sounds reasonable! :-)The changes to the first issue are as
patches in https://bugzilla.gnome.org/show_bug.cgi?id=769604The second
lives (in the head commit) in this branch:
https://git.gnome.org/browse/gnome-maps/log/?h=wip/mlundblad/touch-
search-fixes (in https://git.gnome.org/browse/gnome-
maps/commit/?h=wip/mlundblad/touch-search-
fixes&id=27cf91558c4a5bed00ac5fce578e6d372e9c78e7) (I had originally
thought it would require more changes, therefore the WIP branch).
//Marcus
> Anyway, tentative +1 for the release team from me.
>