GroupWise calendar backend: Small logic overdesign
Jules Colding <[email protected]>
| Newsgroups | gmane.comp.gnome.evolution.devel |
|---|---|
| Message-ID | <1151408428.11032.121.camel__13367.8147373304$1151408555$gmane$org@omc-2.omesc.com> |
Hi,
Just a quick note.... In e_cal_backend_groupwise_create_object() we
find:
###############
if (priv->mode == CAL_MODE_LOCAL) {
in_offline(cbgw);
return GNOME_Evolution_Calendar_RepositoryOffline;
}
###############
About 16 lines later we see:
###############
switch (priv->mode) {
case CAL_MODE_ANY :
case CAL_MODE_REMOTE :
###############
This switch() statement is obviously not needed as the mode can never be
in any other mode but ANY, REMOTE or LOCAL.
Best regards,
jules